Add context module. #311
Merged
Add context module. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #[derive(Clone, Copy)] | ||
| pub struct UContext { | ||
| context: libc::ucontext_t, |
There was a problem hiding this comment.
for direct wrappers like this, I kind of prefer not naming the inner field, and just accessing it via .0. thoughts?
There was a problem hiding this comment.
I would not mind. Feel free to add a corresponding section to the CONVENTIONS, as you have already talked about in the other issue. We should also open a issue that tracks the refactoring process.
Unless we have public members in our structs anywhere, it will not even be a breaking change.
I will leave this unchanged until we have that convention merged into master.
| // provides bindings for them. | ||
| #[cfg(all(target_os = "linux", | ||
| any(target_arch = "x86", target_arch = "x86_64")))] | ||
| pub mod context; |
|
once you fix the |
The module wraps context handling related functions and structs.
|
📌 Commit fbe5696 has been approved by |
homu
added a commit
that referenced
this pull request
Mar 17, 2016
Add context module. The module wraps context handling related functions and structs.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module wraps context handling related functions and structs.