unistd: add fchdir(2) #497
Conversation
|
Note: this has been recently added in libc crate (rust-lang/libc#496), which has been released today. |
|
Excellent, thanks for the contribution @lucab. Can you add an entry to the changelog for this addition? |
|
Also, it would be good to understand what might be happening with this failure. We currently have some known issues with aarch64 which is why it is not gating the green check, but the failure does seem suspicious:
It would appear that the system call is not working as desired in the test environment for these targets. |
lucab
force-pushed
the
to-upstream/fchdir
branch
2 times, most recently
from
1b311a2
to
9ae73b3
Compare
|
Oops, I forgot the changelog, added now. Regarding the cross-test failure, I think I'm hitting a weird combination of an old kernel on travis + some chroot/mount-ns trick by docker + (likely) some bug on aufs/overlayfs. |
|
@lucab Looks like macos has an issue that needs to be resolved in the tests now. |
This introduces a wrapper for fchdir(2), allowing a process to change directory based on an open file descriptor. The underlying function is available in libc crate since 0.2.20.
lucab
force-pushed
the
to-upstream/fchdir
branch
from
9ae73b3
to
0a654e7
Compare
|
@posborne ack. It turned out the test was not canonicalizing paths, so it was fooled by symlinks. |
|
Well, that was fun 🥇. @homu r+ |
|
📌 Commit 0a654e7 has been approved by |
|
⚡ Test exempted - status |
unistd: add fchdir(2) This introduces a wrapper for fchdir(2), allowing a process to change directory based on an open file descriptor. The underlying function is available in libc crate since 0.2.20.
|
@posborne great, thanks! Please ping here back once this gets into a released crate, so I can drop some private wrappers I have in a project which needs this feature. |
This introduces a wrapper for fchdir(2), allowing a process to change
directory based on an open file descriptor.
The underlying function is available in libc crate since 0.2.20.