unix: add fchdir(2) #496
unix: add fchdir(2) #496
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ Thanks! |
|
📌 Commit 7a26079 has been approved by |
unix: add fchdir(2) Add missing [fchdir(2)](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fchdir.html) function - chdir to an open file descriptor. Fixes #495
|
💥 Test timed out |
|
@bors: retry
…On Sun, Jan 15, 2017 at 8:08 PM, bors ***@***.***> wrote:
💥 Test timed out
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#496 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95GKr2E83nau0oLZNfMH5ufipHkwRks5rSu0ugaJpZM4Lj93Q>
.
|
unix: add fchdir(2) Add missing [fchdir(2)](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fchdir.html) function - chdir to an open file descriptor. Fixes #495
|
💥 Test timed out |
|
@bors: retry
…On Mon, Jan 16, 2017 at 4:08 PM, bors ***@***.***> wrote:
💥 Test timed out
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#496 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95L78GBTdjsbzTyYiPSaYecbX6snrks5rTAaGgaJpZM4Lj93Q>
.
|
unix: add fchdir(2) Add missing [fchdir(2)](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fchdir.html) function - chdir to an open file descriptor. Fixes #495
|
☀️ Test successful - status-appveyor, status-travis |
|
@alexcrichton thanks a lot! Please ping here once this reaches a tagged version, so I can get rid of my local symbol (and eventually get this wrapped in nix-rust). |
|
Sure yeah, I'm doing a bump in #499, so we should have a new version shortly |
|
Whoa, that was quick! Followed up in nix with nix-rust/nix#497, thanks a lot. |
…@fiveop Always use libc's socketaddr_storage Since rust-lang/rust#23425 is closed, we no longer need the special case.
Add missing fchdir(2) function - chdir to an open file descriptor.
Fixes #495