-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plasma 6 #286522
Plasma 6 #286522
Conversation
f09c61d
to
ac855eb
Compare
95959c7
to
c193931
Compare
# FIXME: modules should link subdirs of `/share` rather than relying on this | ||
"/share" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be the chance to fix this even if it is lots of work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally yes, but I don't really have the spoons for it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My browser died reviewing this 💀 Can we splitt the autogenerated bits into extra commits to make it somewhat managable?
Also I tried to not repeat myself or focus to much on the details, so one comment could apply to multiple files that have the same pattern.
Forgot something since github ate my first review comment: This should definitely be under pkgs/desktops/{plasma6,kde,..} or the like |
Probably a good idea. Done. |
Questionable, because at least Frameworks definitely doesn't belong under |
0cf09e6
to
8776eeb
Compare
I'm experiencing the same (or a similar) problem. For me, newly installed apps show up, but apps that have changed (pointed to a new path in the nix store) don't change in the app launcher. |
I think plasma seems to hard resolve the |
So, the problem seems to be that when a new Still, it'd be nice to know if this is a NixOS issue, or an upstream issue. Feels like it could be either? |
If anyone else if affected: #292632 |
There are a few lines like
in |
Newly installed packages do not show up for me as well, regardless of if it's a KDE package or not. |
I want to do that a bit later, as part of a bigger migration from Plasma 5 to 6. |
This looks like you might be running the Qt5 version of systemsettings? |
Sorry for the late response. I'm using SDDM currently. Is there a better/preferred option? |
SDDM is what you want, yes. Check the logs for |
I too have this issue on Plasma 6. Since it works for the OP on Arch, I am hoping this gets fixed soon on NixOS. Thank you for packaging Plasma 6 so quickly after the release! |
How are you starting Plasma if those scripts don't work for you? |
I start plasma using SDDM (I hope that's what you were asking). I use home-manager to place a script in ~/.config/plasma-workspace/env. It worked perfectly on plasma 5. |
What are the contents of the script? |
It contains only one line: |
That should really be handled with |
Yes, a different parent could explain why the environment variable isn't available. I set it that way because I wanted that environment variable set only if I am running, say a local Konsole session, that is part of the GUI session, but do not want that variable set when I ssh remotely. |
Why is this happening? I don't have plasma5 enabled |
where can I get the iso which includes plasma 6? |
make sure you don't have explicit referencing of |
|
On plasma6-x11 with intel graphics, I'm getting an occasional hang, where it seems kwin itself gets stuck for 2-3 seconds. Related logs below. Any idea if this could be a NixOS config specific issue? Else will file an upstream bug.
I'm also getting locale (
|
Ark does not have 7-zip, lrzip, and unarchiver plugins which are all included by default in the plasma5 version. |
Description of changes
Yes, the entire thing. I'm sorry in advance.
This is basically a copy of https://github.com/nix-community/kde2nix/, with minimal changes to keep things building.
Some words on the design:
maintainers/scripts/kde
that generate the package expressions and metadatapkgs/kde
is kind of arbitrary, and so ispkgs.kdePackages
, but it's definitely easier to keep everything in one scope for this, as there's a lot of cross-pollinationMe and others have been running this as a daily driver during the betas/RCs, and it's been very stable so far.
The version included right now is 6.0-rc2, the final release is in a few weeks, and I hope to merge it then unless there are major objections.
Also, big thanks to everyone who tested and fixed things, including, but not limited to:
@jansol @mjm @raphaelr @rsniezek @SuperSandro2000
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.