Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for the empty proxy bypass list configured #15

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

sergio-nsk
Copy link
Collaborator

@sergio-nsk sergio-nsk commented Feb 3, 2023

Simplify other config test cases with using predicate assertions instead of expectations.

This should fix the degrading coverage report in #13

Impacted Files Coverage Δ
config.c 56.09% <0.00%> (-1.22%) ⬇️

Simplify other config test cases with using predicate assertions instead of
expectations.
@sergio-nsk sergio-nsk added the continuous integration Continuous integration label Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #15 (8010dc2) into master (8841c3a) will increase coverage by 0.04%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   52.32%   52.36%   +0.04%     
==========================================
  Files          53       53              
  Lines        4369     4369              
  Branches     1021     1020       -1     
==========================================
+ Hits         2286     2288       +2     
  Misses       1449     1449              
+ Partials      634      632       -2     
Flag Coverage Δ
macos 50.69% <46.66%> (+0.08%) ⬆️
ubuntu 43.22% <46.66%> (+0.07%) ⬆️
ubuntu_curl 43.42% <46.66%> (+0.10%) ⬆️
windows 54.76% <42.85%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_config.cc 59.25% <46.66%> (+3.70%) ⬆️
config.c 57.31% <0.00%> (+1.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergio-nsk sergio-nsk merged commit 6451d51 into master Feb 3, 2023
@sergio-nsk sergio-nsk deleted the sergio-nsk/override-bypass-proxy/2 branch February 3, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants