Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add test case for the empty proxy bypass list configured" #22

Closed

Conversation

nmoinvaz
Copy link
Owner

@nmoinvaz nmoinvaz commented Feb 3, 2023

Reverts #15

@nmoinvaz nmoinvaz enabled auto-merge (rebase) February 3, 2023 23:31
@nmoinvaz nmoinvaz added the bug Something isn't working label Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #22 (1256541) into master (17b1b73) will decrease coverage by 9.20%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   52.41%   43.21%   -9.20%     
==========================================
  Files          53       34      -19     
  Lines        4373     2735    -1638     
  Branches     1018      675     -343     
==========================================
- Hits         2292     1182    -1110     
+ Misses       1449     1148     -301     
+ Partials      632      405     -227     
Flag Coverage Δ
macos ?
ubuntu 43.21% <40.00%> (-0.08%) ⬇️
ubuntu_curl ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_config.cc 55.55% <40.00%> (-3.71%) ⬇️
wpad_dhcp_posix.c 0.00% <0.00%> (-63.03%) ⬇️
test/test_wpad.cc 7.14% <0.00%> (-54.93%) ⬇️
wpad_dns.c 0.00% <0.00%> (-32.36%) ⬇️
test/proxycli.c 55.03% <0.00%> (-17.64%) ⬇️
test/test_threadpool.cc 55.55% <0.00%> (-13.89%) ⬇️
util.c 70.09% <0.00%> (-7.12%) ⬇️
test/test_fetch.cc 58.33% <0.00%> (-5.96%) ⬇️
test/test_execute.cc 58.57% <0.00%> (-5.32%) ⬇️
resolver.c 45.83% <0.00%> (-4.93%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nmoinvaz nmoinvaz closed this Feb 3, 2023
auto-merge was automatically disabled February 3, 2023 23:36

Pull request was closed

@nmoinvaz nmoinvaz deleted the revert-15-sergio-nsk/override-bypass-proxy/2 branch February 19, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant