Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty string when setting proxy override settings. #23

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

nmoinvaz
Copy link
Owner

@nmoinvaz nmoinvaz commented Feb 3, 2023

No description provided.

@nmoinvaz nmoinvaz added the enhancement New feature or request label Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #23 (e931440) into master (95f581e) will decrease coverage by 1.32%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   52.40%   51.09%   -1.32%     
==========================================
  Files          53       53              
  Lines        4372     4402      +30     
  Branches     1018     1039      +21     
==========================================
- Hits         2291     2249      -42     
- Misses       1449     1525      +76     
+ Partials      632      628       -4     
Flag Coverage Δ
macos 46.70% <0.00%> (-4.04%) ⬇️
ubuntu 43.56% <0.00%> (+0.29%) ⬆️
ubuntu_curl 44.11% <0.00%> (+0.65%) ⬆️
windows 54.70% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config.c 56.09% <0.00%> (-1.22%) ⬇️
resolver_mac.c 31.46% <0.00%> (-32.97%) ⬇️
config_mac.c 48.69% <0.00%> (-18.81%) ⬇️
test/proxycli.c 71.33% <0.00%> (-1.34%) ⬇️
util.c 77.77% <0.00%> (+0.63%) ⬆️
threadpool_pthread.c 82.55% <0.00%> (+0.67%) ⬆️
test/curl_proxyres.c 61.17% <0.00%> (+9.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nmoinvaz nmoinvaz merged commit 99d3f57 into master Feb 3, 2023
@nmoinvaz nmoinvaz deleted the nathan/master/check-empty-override branch February 3, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants