Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Check for empty string when setting proxy override settings." #29

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

nmoinvaz
Copy link
Owner

@nmoinvaz nmoinvaz commented Feb 9, 2023

Reverts #23

Setting it to emtpy string should override it system settings.

@nmoinvaz nmoinvaz requested a review from sergio-nsk February 9, 2023 00:09
@nmoinvaz nmoinvaz enabled auto-merge (rebase) February 9, 2023 00:09
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #29 (589e4a5) into master (838e0fd) will decrease coverage by 2.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   51.90%   49.70%   -2.20%     
==========================================
  Files          49       53       +4     
  Lines        4150     4482     +332     
  Branches      975     1050      +75     
==========================================
+ Hits         2154     2228      +74     
- Misses       1393     1608     +215     
- Partials      603      646      +43     
Flag Coverage Δ
macos 47.67% <0.00%> (∅)
ubuntu 44.64% <0.00%> (ø)
ubuntu_curl 45.05% <0.00%> (ø)
windows 52.36% <0.00%> (-2.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config.c 57.31% <0.00%> (-0.19%) ⬇️
config_win.c 59.25% <0.00%> (-24.08%) ⬇️
resolver_win8.c 38.70% <0.00%> (-16.13%) ⬇️
test/proxycli.c 59.33% <0.00%> (-10.67%) ⬇️
util.c 75.52% <0.00%> (-0.94%) ⬇️
resolver.c 50.75% <0.00%> (-0.02%) ⬇️
wpad_dns.c 32.35% <0.00%> (ø)
wpad_dhcp.c 0.00% <0.00%> (ø)
config_mac.c 46.28% <0.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nmoinvaz nmoinvaz merged commit 0541cdd into master Feb 9, 2023
@nmoinvaz nmoinvaz deleted the revert-23-nathan/master/check-empty-override branch February 9, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants