Skip to content

Commit

Permalink
Target Node.js v14 in appveyor.yml
Browse files Browse the repository at this point in the history
- Tests in `.travis.yml` target Node.js v14.
- Tests in `appveyor.yml` should also target Node.js v14.
- Updates `engines` in `package.json` to Node.js >= 10.
- Includes test-fixes by @addaleax.

PR-URL: #45
  • Loading branch information
joelpurra authored Sep 5, 2020
1 parent eadcf5d commit b0809c2
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 7 deletions.
1 change: 1 addition & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ environment:
# node.js
- nodejs_version: "10"
- nodejs_version: "12"
- nodejs_version: "14"

platform:
- x86
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "ref-napi",
"description": "Turn Buffer instances into \"pointers\"",
"engines": {
"node": ">= 6.0"
"node": ">= 10.0"
},
"keywords": [
"native",
Expand Down
10 changes: 6 additions & 4 deletions test/pointer.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,14 @@ describe('pointer', function() {
parent = null;
gc();
setImmediate(() => {
assert(parent_gc, '"parent" has not been garbage collected');
gc();
setImmediate(() => {
assert(parent_gc, '"parent" has not been garbage collected');
gc();
setImmediate(() => {
assert(child_gc, '"child" has not been garbage collected');
done();
setImmediate(() => {
assert(child_gc, '"child" has not been garbage collected');
done();
});
});
});
});
Expand Down
6 changes: 4 additions & 2 deletions test/reinterpret.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,10 @@ describe('reinterpret()', function() {
other = null;
gc();
setImmediate(() => {
assert(otherGCd, '"other" has not been garbage collected');
assert(origGCd, '"buf" has not been garbage collected');
setImmediate(() => {
assert(otherGCd, '"other" has not been garbage collected');
assert(origGCd, '"buf" has not been garbage collected');
});
});
});
});

0 comments on commit b0809c2

Please sign in to comment.