Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target Node.js v14 in appveyor.yml #45

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Target Node.js v14 in appveyor.yml #45

merged 1 commit into from
Sep 5, 2020

Conversation

joelpurra
Copy link
Contributor

@joelpurra joelpurra commented Sep 5, 2020 •
edited
Loading

  • Tests in .travis.yml target Node.js v14.
  • Tests in appveyor.yml should also target Node.js v14.
  • Updates engines in package.json to Node.js >= 10.
  • Includes test-fixes by @addaleax.

@coveralls
Copy link

coveralls commented Sep 5, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 74.414% when pulling cfe74f0 on joelpurra:appveyor-nodejs-v14 into eadcf5d on node-ffi-napi:latest.

@joelpurra joelpurra mentioned this pull request Sep 5, 2020
Merged
@addaleax
Copy link
Contributor

addaleax commented Sep 5, 2020

I’ve pushed what I assume would be a fix for the CI failures, let’s see if it works :)

@joelpurra
Copy link
Contributor Author

@addaleax: alright, that worked! To verify, I'll remove the node-addon-api upgrade and let the CI run again. Your fix is a fixup! so I'll also squash it I guess.

@joelpurra
Target Node.js v14 in appveyor.yml
cfe74f0 
- Tests in `.travis.yml` target Node.js v14.
- Tests in `appveyor.yml` should also target Node.js v14.
- Updates `engines` in `package.json` to Node.js >= 10.
- Includes test-fixes by @addaleax.

See

- #45
@joelpurra
Copy link
Contributor Author

@addaleax: tests pass! Guess the node-addon-api update isn't required for Node.js v14 compatibility. Will investigate locally.

@addaleax addaleax merged commit b0809c2 into node-ffi-napi:latest Sep 5, 2020
@joelpurra joelpurra deleted the appveyor-nodejs-v14 branch September 5, 2020 18:21
@joelpurra joelpurra restored the appveyor-nodejs-v14 branch September 5, 2020 18:21
@joelpurra joelpurra deleted the appveyor-nodejs-v14 branch September 5, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelpurra @coveralls @addaleax