Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python3 strategic initiative #781

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Remove Python3 strategic initiative #781

merged 1 commit into from
Dec 5, 2019

Conversation

sam-github
Copy link
Contributor

Also, reindented file, some of the tables were wonky.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

After discussion with @cclauss, we conclude that the Python3 push is
complete, and follow on issues as they come up can be handled via the
normal Issue/PR process. Regular attention by the TSC is no longer
required.
@sam-github sam-github changed the title Add Sam and Christian to Python3/Gyp initiative Remove Python3 strategic initiative Nov 28, 2019
@sam-github
Copy link
Contributor Author

I had a videochat with @cclauss this morning, and we conclude this is no longer necessary to be a strategic initiative, so I removed it. New commit message:

Remove Python3 strategic initiative

After discussion with @cclauss, we conclude that the Python3 push is
complete, and follow on issues as they come up can be handled via the
normal Issue/PR process. Regular attention by the TSC is no longer
required.

@sam-github
Copy link
Contributor Author

Given how different the PR is :-) I re-requested review.

@cclauss
Copy link

cclauss commented Nov 29, 2019

Thanks all for your guidance on this effort. We are at the stage where any Python 3 incompatibilities that we find should be treated as bugs to be fixed. This community does impressive work that helps so many people around the globe.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -53,8 +52,10 @@ and have the support needed.
[node#18106]: https://github.com/nodejs/node/issues/18106
[fishrock123]: https://github.com/fishrock123
[addaleax]: https://github.com/addaleax
[cclauss]: https://github.com/cclauss
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't needed now that initiative is removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks.

[mhdawson]: https://github.com/mhdawson
[rvagg]: https://github.com/rvagg
[sam-github]: https://github.com/sam-github
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't needed now that initiative is removed

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @nschonni's comments are address

mhdawson added a commit to mhdawson/io.js that referenced this pull request Nov 29, 2019
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.
mhdawson added a commit to nodejs/node that referenced this pull request Dec 3, 2019
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

PR-URL: #30722
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@sam-github sam-github merged commit 2f8aba4 into nodejs:master Dec 5, 2019
@sam-github sam-github deleted the assign-py3-gyp branch December 5, 2019 16:25
targos pushed a commit to nodejs/node that referenced this pull request Dec 9, 2019
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

PR-URL: #30722
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants