Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update status of Python 3 support #30722

Closed
wants to merge 4 commits into from
Closed

doc: update status of Python 3 support #30722

wants to merge 4 commits into from

Conversation

mhdawson
Copy link
Member

Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@mhdawson
doc: update status of Python 3 support
be9c0e6 
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 29, 2019
@mhdawson
Copy link
Member Author

@sam-github, @cclauss this reflect my understanding, can you validate?

targos
targos reviewed Nov 29, 2019
View reviewed changes
BUILDING.md Outdated Show resolved Hide resolved
sam-github
sam-github reviewed Nov 29, 2019
View reviewed changes
BUILDING.md Outdated Show resolved Hide resolved
sam-github
sam-github approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions to simplify, but generally LGTM

mhdawson and others added 3 commits December 3, 2019 10:37
@mhdawson @targos
Update BUILDING.md
57d510e 
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
@mhdawson
Update BUILDING.md
cc4d4f8
@mhdawson
squash: address comments
2d388e5
@mhdawson
Copy link
Member Author

mhdawson commented Dec 3, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4098/

@cclauss
Copy link
Contributor

cclauss commented Dec 3, 2019 •
edited
Loading

Given that Python 2 end of life is in 29 days, I would recommend the following simplification:

The Node.js project can use either Python 2 or Python 3 in its build process. If both are installed, then Python 3 will be used. If only Python 2 is available, then it will be used instead. Whenever possible, we recommend that you build and test with Python 3.

@mhdawson
Copy link
Member Author

mhdawson commented Dec 3, 2019

CI good, just waiting for Travis to complete.

@mhdawson
Copy link
Member Author

mhdawson commented Dec 3, 2019

Travis is good landing.

mhdawson added a commit that referenced this pull request Dec 3, 2019
@mhdawson
doc: update status of Python 3 support
7bee77f 
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

PR-URL: #30722
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@mhdawson
Copy link
Member Author

mhdawson commented Dec 3, 2019

Landed as 7bee77f

@mhdawson mhdawson closed this Dec 3, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@mhdawson @targos
doc: update status of Python 3 support
145f881 
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

PR-URL: #30722
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged