add ccache to jenkins_path for macOS #1347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mhdawson
pushed a commit
that referenced
this pull request
Jun 18, 2018
PR-URL: #1347 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed as 01f2dd0 |
|
Rolled this out across all Mac machines |
|
@maclover7 did you restart the jenkins agent as well? |
|
@gdams Yep, I'm working on a PR to add this to Ansible |
|
We might want to roll this back. It makes command line testing harder since the environments for the jenkins agent and a vanilla ssh login are different. AFAICT other jenkins daemonizers are also kept minimal... |
|
ccache is also added to the vanilla ssh login path so there should be no issue? |
rvagg
added a commit
that referenced
this pull request
Oct 14, 2019
rvagg
added a commit
that referenced
this pull request
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix means that ccache is now in the path on new macs. I have tested tested this change on
test-macstadium-macos10.10-x64-1and the jenkins_path now shows to be/usr/localopt/ccache/libexec:/usr/bin:/bin:/usr/sbin:/sbin