Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: macos: /usr/localopt->/usr/local/opt & install ccache #1956

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 14, 2019

I'm not sure of the backstory here, this path was introduced in the original PRs:

Ref: #971
Ref: #1347

But afaik /usr/localopt has never been a thing. /usr/local/opt is where this stuff is at.

The macos machines all seem to be set up to have /usr/localopt in start.sh and /etc/paths, but because /usr/local/opt is in there I believe it just mostly works.

#1955 reports slow release builds on macos, but that's because there's no ccache. I tried running the playbook but it failed at doing something in /home, so there's more work to be done on that. I don't even know if it installs ccache by brew but I did that manually for now to get it going.

@rvagg rvagg force-pushed the rvagg/macos-localopt branch from f811975 to 00c7003 Compare October 14, 2019 02:24
@rvagg rvagg changed the title ansible: fix macos /usr/localopt -> /usr/local/opt ansible: macos: /usr/localopt->/usr/local/opt & install ccache Oct 14, 2019
@rvagg
Copy link
Member Author

rvagg commented Oct 14, 2019

Added a new change that installs ccache as well, I don't believe it's anywhere in the homebrew install process on these machines.

With https://github.com/nodejs-private/secrets/pull/48 and these changes I get through an ansible run on release-macstadium-macos10.11-x64-1.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg rvagg merged commit 2c0e049 into master Oct 16, 2019
@rvagg rvagg deleted the rvagg/macos-localopt branch October 16, 2019 02:39
@richardlau richardlau mentioned this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants