Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: move 10.x release sources off osx #2347

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

AshCripps
Copy link
Member

I want to propose moving the build of 10.x release sources off osx onto linux with the rest of the release lines.

This will allow us to migrate off of our old macstadium vsphere (#2315) as this is our only dependency upon osx 10.10.

Im not 100% sure if this is possible to test before merging.

@AshCripps AshCripps requested review from rvagg and richardlau June 11, 2020 14:20
@richardlau
Copy link
Member

Im not 100% sure if this is possible to test before merging.

Probably not without cloning the job in the release-ci to change where it picks up the script from.

@AshCripps
Copy link
Member Author

Probably not without cloning the job in the release-ci to change where it picks up the script from.

Yeah I didnt think so, theres no release scheduled for a couple weeks from what I can see in the release repo so merging and running a couple test release-ci jobs to verify should be good enough

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to test this, you can edit iojs+release to point to this branch's VersionSelectorScript and run a test build (pls use proper date and commit for that). Remember to set it back to master once you're done though.

@AshCripps
Copy link
Member Author

ive ran a sample build before changes for comparison: https://ci-release.nodejs.org/job/iojs+release/6102/

build with changes: https://ci-release.nodejs.org/job/iojs+release/6103/

@AshCripps
Copy link
Member Author

Both builds pass and the outputs look the same.

Ive revert the job back to using master's versionselectorscript

@AshCripps AshCripps merged commit 105c60e into nodejs:master Jun 12, 2020
@AshCripps AshCripps deleted the update-release-sources branch June 12, 2020 12:34
@rvagg
Copy link
Member

rvagg commented Jun 15, 2020

I had a quick look and I don't think we're stating anywhere how the tarballs are built, so we're not officially tied to their format. There will be a difference in the tarball format but it should be an improvement in compatibility rather than introducing potential incompatibilities. But you never know what's going on out there in the wild, there's always surprises when we change the most minor things! 🤞 thanks for this @AshCripps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants