v12.18.1 proposal #33811
Merged
v12.18.1 proposal #33811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes makes all stream in a pipeline emit 'error' in case of an abnormal termination of the pipeline. If the last stream is currently being async iterated, this change will make the iteration reject accordingly. See: #30861 Fixes: #28194 PR-URL: #30869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: #32797 (comment) PR-URL: #32798 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #33185 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #33194 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
If package authors don't explicitly include all previously supported entry points introducing package.exports will be a Semver-Major change. Add a warning about this behavior and offer two potential solutions for module authors. Refs: then/is-promise#20 PR-URL: #33074 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #33037 PR-URL: #33236 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Fixes: #33153 Change documentation to make async_resource required as opposed to optional in napi-async_init. Changes over time mean this parameter is required for proper operation of async hooks (which are still experimental). This changes the documentation to document what callers should do. We are doing this only in the doc in order to avoid a breaking change in N-API. We could create a new version of the method for which the parametrer is enforced as mandatory but we should only do that once async hooks is no longer experimental. In that case we could deprecate (but not remove this version of the method). Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #33181 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Currently from will eagerly buffer up items which means that errors are also eagerly encountered and items which are buffer when an error occurs will be discarded, which is inconsistent with how generators work. Fixes: #29428 PR-URL: #33201 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Adds a test to ensure that napi_get_value_uint32 returns 0xffffffff for -1. Re: #33117 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #33252 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
AsyncWrap is a private API and should not be mentioned in the documentation. PR-URL: #33249 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #33248 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #33235 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #33230 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #33217 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
It returns zero-filled memory since v8.0.0. PR-URL: #33198 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #33179 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Ran into #30189, solved by this comment: #30189 (comment) Refs: #30189 PR-URL: #33174 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
PR-URL: #33211 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add capabilities to common test module to detect and skip tests
on dumb terminals.
In some of our build environments, like s390x, the terminal
is a dumb terminal meaning it has very rudimentary capabilities.
These in turn prevent some of the tests from completing with errors
as below.
not ok 1777 parallel/test-readline-tab-complete
---
duration_ms: 0.365
severity: fail
exitcode: 1
stack: |-
assert.js:103
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
'\t' !== ''
at /home/abuild/rpmbuild/BUILD/node-git.8698dd98bb/test/parallel/test-readline-tab-complete.js:63:14
at Array.forEach (<anonymous>)
at /home/abuild/rpmbuild/BUILD/node-git.8698dd98bb/test/parallel/test-readline-tab-complete.js:18:17
at Array.forEach (<anonymous>)
at Object.<anonymous> (/home/abuild/rpmbuild/BUILD/node-git.8698dd98bb/test/parallel/test-readline-tab-complete.js:17:3)
at Module._compile (internal/modules/cjs/loader.js:1176:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10)
at Module.load (internal/modules/cjs/loader.js:1040:32)
at Function.Module._load (internal/modules/cjs/loader.js:929:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: '\t',
expected: '',
operator: 'strictEqual'
}
...
PR-URL: #33165
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #33100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Calling `decipher.setAuthTag` after `decipher.update` will result in an error like `Unsupported state or unable to authenticate data`. The example code in [CCM mode](https://nodejs.org/docs/latest-v14.x/api/crypto.html#crypto_ccm_mode) is correct, but to demonstrate the mistake in the documentation you can take the same example and move the `setAuthTag` call to in between `update` and `final` you will see the error.
* Initialize structure members. * Factor out common `Debug()` prefix. * Remove unused `text_region` field. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #33255 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
The WASM memory interfacing logic was wrong (particularly around the size of __wasi_subscription_t). This commit fixes the logic. PR-URL: #33250 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
We do not support importing named exports from a CJS module. This change decorates the error message for missing named exports in the case where the module being imported is expected to be CJS by the ESM loader. Signed-off-by: Myles Borins <myles.borins@gmail.com> PR-URL: #33256 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This isn’t conceptually tied to anything Node.js-specific at all. PR-URL: #33272 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
In previous implementation it was clubbed into declaration of scheduling policies and fetching the schedulingPolicy. Now they are separate variables, so that in future if one want to add new scheduling policy. It is much simpler and not obsfucated. PR-URL: #32663 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
approved these changes
Jun 16, 2020
|
The proposal looks good to me. I have no idea what could have caused this new compiler error... |
|
@codebytere looks like it was my fault, I removed the release source builds on osx10.10 in nodejs/build#2347 but forgot to remove the label from the job so it ran here by accident. Have removed the label now so it shouldn't happen again. |
|
@nodejs/build do you know what might have happened here: https://ci-release.nodejs.org/job/iojs+release/6114/nodes=osx1015-release-pkg/console ? Looks like a few things failing: https://ci-release.nodejs.org/job/iojs+release/6114/ |
|
@nodejs/releasers thoughts on moving this to tomorrow? Given that this looks like a build issue i'm not sure I can solve it myself before tonight :( |
|
+1 to delaying. I've been stuck in meetings all day but can take a look a bit later tonight |
codebytere
force-pushed
the
v12.18.1-proposal
branch
from
10c68cd to
6665f73
Compare
|
Errors like this, with no obvious cause (you do have to search the stacktrace for possible causes - in this case there's a "can't delete file" that could be it, but 🤷), you can try re-running. Here's a re-run that gets green for the macos builders: https://ci-release.nodejs.org/job/iojs+release/6115/, I think you might have all assets in staging now with this run. |
codebytere
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jun 17, 2020
codebytere
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jun 17, 2020
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2020-06-17, Version 12.18.1 'Erbium' (LTS), @codebytere
Notable Changes
Commits
ba93c8d87d] - async_hooks: clear async_id_stack for terminations in more places (Anna Henningsen) #33347964adfafa5] - buffer: improve copy() performance (Nikolai Vavilov) #332145c7176bf90] - deps: update to uvwasi 0.0.9 (Colin Ihrig) #33445402aa1b840] - deps: upgrade to libuv 1.38.0 (Colin Ihrig) #334464d6f56a76a] - deps: upgrade npm to 6.14.5 (Ruy Adorno) #3323998a7026311] - doc: document module.path (Antoine du Hamel) #333239572701705] - doc: add fs.open() multiple constants example (Ethan Arrowood) #332817d8a226958] - doc: fix typos in handle scope descriptions (Tobias Nießen) #332670c9b826ef8] - doc: update function description fordecipher.setAAD(Jonathan Buhacoff) #330954749156f4b] - doc: add comment about highWaterMark limit (Benjamin Gruenbaum) #33432a48aeb3f74] - doc: clarify about the Node.js-only extensions in perf_hooks (Joyee Cheung) #33199a9ed287f00] - doc: fix extension in esm example (Gus Caplan) #33408d2897a2836] - doc: enhance guides by fixing and making grammar more consistent (Chris Holland) #331523d8ba292e2] - doc: add examples for implementing ESM (unknown) #33168318fcf8188] - doc: add note about clientError writable handling (Paolo Insogna) #3330830c9cb556f] - doc: fix typo in n-api.md (Daniel Bevenius) #333199dde1db332] - doc: add warning for socket.connect reuse (Robert Nagy) #332040c7cf24431] - doc: correct description ofdecipher.setAuthTagin crypto.md (Jonathan Buhacoff)59619b0c9a] - doc: mention python3-distutils dependency in BUILDING.md (osher) #331740cee4c3eae] - doc: removed unnecessary util imports from vm examples (Karol Walasek) #33179903862089b] - doc: update Buffer(size) documentation (Nikolai Vavilov) #331988b44be9b26] - doc: add Uint8Array toendandwrite(Pranshu Srivastava) #332174a584200f8] - doc: specify unit of time passed tofs.utimes(Simen Bekkhus) #33230ad7a890597] - doc: add troubleshooting guide for AsyncLocalStorage (Andrey Pechkurov) #332482262962ab7] - doc: remove AsyncWrap mentions from async_hooks.md (Andrey Pechkurov) #33249ac5cdd682a] - doc: add warnings about transferring Buffers and ArrayBuffer (James M Snell) #33252033bc96ec1] - doc: update napi_async_init documentation (Michael Dawson) #33181ea3a68f74f] - doc: doc and test URLSearchParams discrepancy (James M Snell) #33236c6cf0483f2] - doc: explicitly doc package.exports is breaking (Myles Borins) #33074e572cf93e5] - doc: fix style and grammer in buffer.md (Nikolai Vavilov) #331945d80576889] - errors: skip fatal error highlighting on windows (Thomas) #33132a029dca90e] - esm: improve commonjs hint on module not found (Antoine du Hamel) #33220c129e8809e] - fs: forbid concurrent operations on Dir handle (Anna Henningsen) #33274aa4611cccb] - fs: clean up Dir.read() uv_fs_t data before calling into JS (Anna Henningsen) #33274fa4a37c57b] - http2: comment on usage ofObject.create(null)(Pranshu Srivastava) #3318366dbaff848] - http2: addbytesWrittentest forHttp2Stream(Pranshu Srivastava) #3316259769c4d14] - lib: fix typo in timers insert function comment (Daniel Bevenius) #333016881410951] - lib: refactored scheduling policy assignment (Yash Ladha) #326639017bce54b] - lib: fix grammar in internal/bootstrap/loaders.js (szTheory) #33211d64dbfa1e7] - meta: add issue template for API reference docs (Derek Lewis) #329444f6e4ae49d] - module: add specific error for dir import (Antoine du HAMEL) #3322077caf92314] - module: better error for named exports from cjs (Myles Borins) #3325682da74b1cd] - n-api: add uint32 test for -1 (Gabriel Schulhof)68551d22d2] - perf_hooks: fix error message for invalid entryTypes (Michaël Zasso) #33285e67df04df2] - src: use BaseObjectPtr in StreamReq::Dispose (James M Snell) #33102c797c7c7ab] - src: reduce duplication in RegisterHandleCleanups (Daniel Bevenius) #33421548db2e5b9] - src: remove unused IsolateSettings variable (Daniel Bevenius) #33417e668376b5b] - src: remove unused misc variable (Daniel Bevenius) #334179883ba6ddd] - src: add promise_resolve to SetupHooks comment (Daniel Bevenius) #33365b924910fe7] - src: distinguish refed/unrefed threadsafe Immediates (Anna Henningsen) #3332029d24db914] - src: add #include <string> in json_utils.h (Cheng Zhao) #33332a0bc2e3b64] - src: replace to CHECK_NOT_NULL in node_crypto (himself65) #333831f159e45f2] - src: add primordials to arguments comment (Daniel Bevenius) #33318fe780a5fe0] - src: remove unused using declarations in node.cc (Daniel Bevenius) #3326182c43d1594] - src: delete unused variables to resolve compile time print warning (rickyes) #33358548672d39c] - src: use MaybeLocal.ToLocal instead of IsEmpty (Daniel Bevenius) #33312f27ae6ef46] - src: fix typo in comment in async_wrap.cc (Daniel Bevenius) #33350b6300793fb] - src: remove unnecessary Isolate::GetCurrent() calls (Anna Henningsen) #33298642f81317e] - src: fix invalid windowBits=8 gzip segfault (Ben Noordhuis) #33045a5e8c5ce0d] - src: split out callback queue implementation from Environment (Anna Henningsen) #33272ed62d43e79] - src: clean up large pages code (Gabriel Schulhof) #33255c05483483f] - Revert "src: add test/abort build tasks" (Richard Lau) #33196b43fc64aa7] - Revert "src: add aliased-buffer-overflow abort test" (Richard Lau) #33196edf75e4299] - src: use basename(argv0) for --trace-uncaught suggestion (Anna Henningsen) #327984294d92b26] - stream: make from read one at a time (Robert Nagy) #33201194789f25b] - stream: make all streams error in a pipeline (Matteo Collina) #308695da7d52a9f] - test: regression tests for async_hooks + Promise + Worker interaction (Anna Henningsen) #333479f594be75a] - test: fix test-dns-idna2008 (Rich Trott) #3336733a787873f] - test: refactor WPTRunner (Joyee Cheung) #33297fa1631355f] - test: update WPT interfaces and hr-time (Joyee Cheung) #33297c459832e4b] - test: fix test-net-throttle (Rich Trott) #33329cd92052935] - test: add hr-time Web platform tests (Michaël Zasso) #332870177cbf9e0] - test: rename test-lookupService-promises (rickyes) #33100139eb6bd68] - test: skip some console tests on dumb terminal (Adam Majer) #331651766514c5b] - test: add tests for options.fs in fs streams (Julian Duque) #331857315c2288a] - tls: fix --tls-keylog option (Alba Mendez) #33366e240d56983] - tools: update dependencies for markdown linting (Rich Trott) #334122645b1c85b] - tools: update ESLint to 7.0.0 (Colin Ihrig) #33316cdd7d3a66d] - tools: remove obsolete no-restricted-syntax eslint rules (Ruben Bridgewater) #321615d5e66c10c] - tools: add eslint rule to only pass through 'test' to debuglog (Ruben Bridgewater) #3216122f2c2c871] - wasi: fix poll_oneoff memory interface (Colin Ihrig) #3325033aacbefb1] - wasi: prevent syscalls before start (Tobias Nießen) #332355eed20b3b7] - worker: fix race condition in node_messaging.cc (Anna Henningsen) #33429b4d903402b] - worker: fix crash when .unref() is called during exit (Anna Henningsen) #333948a926982e5] - worker: call CancelTerminateExecution() before exiting Locker (Anna Henningsen) #33347631e433cf5] - zlib: reject windowBits=8 when mode=GZIP (Ben Noordhuis) #33045