Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: grammar fix in internal/bootstrap/loaders.js #33211

Closed
wants to merge 1 commit into from

Conversation

szTheory
Copy link
Contributor

@szTheory szTheory commented May 2, 2020

Comment grammar fix

Checklist

Copy link
Member

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 3, 2020
@nodejs-github-bot
Copy link
Collaborator

@addaleax
Copy link
Member

addaleax commented May 7, 2020

@BridgeAR I know the PR title is misleading and this only changes a comment, but we have had bugs in the past that were exposed through changes to comments, so I’d prefer to stick to our rules and run full CI :)

@BridgeAR
Copy link
Member

BridgeAR commented May 7, 2020

@addaleax our rules explicitly mention that these changes do not require a full CI:

Pull requests that only change documentation and comments can use GitHub Actions results.

@addaleax
Copy link
Member

addaleax commented May 7, 2020

Huh, okay. Didn’t know that 👍

addaleax pushed a commit that referenced this pull request May 7, 2020
PR-URL: #33211
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax
Copy link
Member

addaleax commented May 7, 2020

Landed in 4d4e3c3, thanks for the PR!

@addaleax addaleax closed this May 7, 2020
codebytere pushed a commit that referenced this pull request May 11, 2020
PR-URL: #33211
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
codebytere pushed a commit that referenced this pull request Jun 7, 2020
PR-URL: #33211
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants