lib: redirect homedir for modules being tested #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests for some modules write into `os.homedir()` and are not cleaning up afterwards. This is accumulating over time on our CI and require periodic manual cleaning. Redirect the environment variables used by `os.homedir()` into CITGM's temporary directory for the module being tested, which gets removed at the end of the test run. Refs: nodejs/build#1908 (comment)
targos
approved these changes
Oct 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
==========================================
+ Coverage 95.44% 95.46% +0.02%
==========================================
Files 27 27
Lines 879 883 +4
==========================================
+ Hits 839 843 +4
Misses 40 40
Continue to review full report at Codecov.
|
BridgeAR
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for some modules write into
os.homedir()and are notcleaning up afterwards. This is accumulating over time on our CI
and require periodic manual cleaning.
Redirect the environment variables used by
os.homedir()intoCITGM's temporary directory for the module being tested, which gets
removed at the end of the test run.
Refs: nodejs/build#1908 (comment)
Checklist
npm testpasseshere