http: keep F_LENIENT between messages
#34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`F_LENIENT` flag should not be reset along with the other flags when starting parsing a new message. This setting should remain on for the lifetime of the parser or until `llhttp_set_lenient(..., 0)`.
This was referenced Nov 21, 2019
addaleax
approved these changes
Nov 21, 2019
bnoordhuis
approved these changes
Nov 21, 2019
tniessen
approved these changes
Nov 21, 2019
sam-github
approved these changes
Nov 21, 2019
indutny
added a commit
that referenced
this pull request
Nov 21, 2019
`F_LENIENT` flag should not be reset along with the other flags when starting parsing a new message. This setting should remain on for the lifetime of the parser or until `llhttp_set_lenient(..., 0)`. PR-URL: #34 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
|
Landed in 5f29a33, thank you everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F_LENIENTflag should not be reset along with the other flags whenstarting parsing a new message. This setting should remain on for the
lifetime of the parser or until
llhttp_set_lenient(..., 0).cc @nodejs/http @addaleax @bnoordhuis