Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: keep F_LENIENT between messages #34

Closed
wants to merge 1 commit into from
Closed

http: keep F_LENIENT between messages #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/native/http.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,11 @@ int llhttp__after_message_complete(llhttp_t* parser, const char* p,
int should_keep_alive;

should_keep_alive = llhttp_should_keep_alive(parser);
parser->flags = 0;
parser->finish = HTTP_FINISH_SAFE;

/* Keep `F_LENIENT` flag between messages, but reset every other flag */
parser->flags &= F_LENIENT;

/* NOTE: this is ignored in loose parsing mode */
return should_keep_alive;
}
Expand Down
29 changes: 29 additions & 0 deletions test/request/lenient.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,35 @@ off=33 headers complete method=1 v=1/1 flags=100 content_length=0
off=33 message complete
```

## Second request header value with lenient

<!-- meta={"type": "request-lenient"} -->
```http
GET /url HTTP/1.1
Header1: Okay


GET /url HTTP/1.1
Header1: \f


```

```log
off=0 message begin
off=4 len=4 span[url]="/url"
off=19 len=7 span[header_field]="Header1"
off=28 len=4 span[header_value]="Okay"
off=36 headers complete method=1 v=1/1 flags=100 content_length=0
off=36 message complete
off=38 message begin
off=42 len=4 span[url]="/url"
off=57 len=7 span[header_field]="Header1"
off=66 len=1 span[header_value]="\f"
off=71 headers complete method=1 v=1/1 flags=100 content_length=0
off=71 message complete
```

## Header value without lenient

<!-- meta={"type": "request"} -->
Expand Down