Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-node: detect CI status also from the GitHub API #324

Closed
joyeecheung opened this issue Feb 7, 2019 · 4 comments · Fixed by #469
Closed

git-node: detect CI status also from the GitHub API #324

joyeecheung opened this issue Feb 7, 2019 · 4 comments · Fixed by #469
Labels
git-node

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Feb 7, 2019 •
edited
Loading

Currently it only parses the thread and looks for CI links pasted manually, but it can also just query the GitHub API for the status of the last commit in the PR in case someone forgets to paste the link.

We cannot replace the link parsing entirely with this though because the github bot does not always update the CI status reliably. If the node-test-commit status of the last commit is not green we could also print a warning (again we cannot just error because the bot or Jenkins is not always reliable)
@joyeecheung joyeecheung mentioned this issue Feb 7, 2019
Closed
3 tasks
@sam-github
Copy link
Contributor

I think @richardlau made a good point in nodejs/node#25861 (comment) that having ci: is good for after the fact observation.

The suggestion I would make for git node land is that when it says no CI detected, it mention specifically that it is looking for a ci: comment. You could print a message saying "ci passed, but not comment, please add ci: ... as a comment.... but honestly, just clarity about what the tool is looking for would be enough, IMO.

@joyeecheung
Copy link
Member Author

@sam-github That's a good point. Although it would still be useful to query the CI status and display a hint if it's not green or yellow, so that the user is aware that they are pushing a commit to master that did not fully pass the CI (even when it's just flaked).

@mmarchini mmarchini mentioned this issue Oct 1, 2019
Closed
@mmarchini
Copy link
Contributor

Once we have the GitHub API integration, we can also add a config option to only use it, since not all our project use Jenkins as a CI.

mmarchini added a commit to mmarchini/node-core-utils that referenced this issue Aug 9, 2020
@mmarchini
feat: check Actions and handle doc-only changes
9d2e214 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs#324
Ref: nodejs/node#32335
@mmarchini mmarchini mentioned this issue Aug 9, 2020
Merged
mmarchini added a commit to mmarchini/node-core-utils that referenced this issue Aug 9, 2020
@mmarchini
feat: check Actions and handle doc-only changes
5ce5265 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs#324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
mmarchini added a commit to mmarchini/node-core-utils that referenced this issue Aug 15, 2020
@mmarchini
feat: check Actions and handle doc-only changes
b014e26 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs#324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
mmarchini added a commit to mmarchini/node-core-utils that referenced this issue Aug 15, 2020
@mmarchini
feat: check Actions and handle doc-only changes
1efbc0e 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs#324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Aug 16, 2020
@mmarchini mmarchini removed the stale label Aug 16, 2020
mmarchini added a commit to mmarchini/node-core-utils that referenced this issue Aug 20, 2020
@mmarchini
feat: check Actions and handle doc-only changes
2445dbf 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs#324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
mmarchini added a commit that referenced this issue Aug 20, 2020
@mmarchini
feat: check Actions and handle doc-only changes
855f1d4 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: #324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
@github-actions github-actions bot mentioned this issue Mar 19, 2022
Closed
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this issue Nov 2, 2022
feat: check Actions and handle doc-only changes
1e76858 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs/node-core-utils#324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
@github-actions github-actions bot mentioned this issue Nov 2, 2022
Open
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this issue Nov 10, 2022
@renawolford6
feat: check Actions and handle doc-only changes
35c1737 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs/node-core-utils#324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
@github-actions github-actions bot mentioned this issue Nov 10, 2022
Open
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this issue Jan 27, 2023
@logictitans
feat: check Actions and handle doc-only changes
a9dab03 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs/node-core-utils#324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this issue Jan 27, 2023
@gerkai
feat: check Actions and handle doc-only changes
37b0b53 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs/node-core-utils#324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
@github-actions github-actions bot mentioned this issue Mar 15, 2023
Open
shovon58 pushed a commit to shovon58/node-core-utils that referenced this issue Jun 9, 2023
@paxaxel223
feat: check Actions and handle doc-only changes
e0e8ee1 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs/node-core-utils#324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this issue Sep 14, 2023
@patrickm68
feat: check Actions and handle doc-only changes
50f94c3 
Doc-only changes don't need a full Jenkins CI, instead we can check
if the last Actions run was successful. Therefore this commit also adds
check for Action runs. Jenkins CI messages were improved as well.

Fix: nodejs/node-core-utils#324
Fix: nodejs/node#32335
Fix: nodejs/node#29770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
git-node
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: check Actions and handle doc-only changes mmarchini/node-core-utils
3 participants
@sam-github @mmarchini @joyeecheung