-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src,win: add support for fetching arm64 node.lib #1875
src,win: add support for fetching arm64 node.lib #1875
Conversation
@richard-townsend-arm thanks for opening this PR! This has been on my backlog for a while, because some more changes are needed. Now it's almost done:
|
Cool, thanks for that @joaocgreis: I'm happy for your fixups to go into into this PR. |
Windows on Arm support is available in some versions of Node.js v12 and Electron v6. This update allows node-gyp to fetch the appropriate node.lib to build native modules. If an arm64 binary is not available for the target node version, it's logged but ignored. arm64 is not expected to work in very old node.lib distribution formats, the test URLs in these cases are added to be consistent with x64.
edec5b5
to
83864c2
Compare
Windows on Arm support is available in some versions of Node.js v12 and Electron v6. This update allows node-gyp to fetch the appropriate node.lib to build native modules. If an arm64 binary is not available for the target node version, it's logged but ignored. arm64 is not expected to work in very old node.lib distribution formats, the test URLs in these cases are added to be consistent with x64. PR-URL: #1875 Reviewed-By: João Reis <reis@janeasystems.com>
Tested with v12.8.0 from unofficial builds. CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/156/ Landed in 2441932 |
Published ARM64 release of v12.10.0: https://unofficial-builds.nodejs.org/download/release/v12.10.0/ (v12.11.0 has an issue with unofficial builds, fix in nodejs/unofficial-builds#10). To use node-gyp directly from the master branch, including this PR:
|
Windows on Arm support is available in some versions of Node.js v12 and Electron v6. This update allows node-gyp to fetch the appropriate node.lib to build native modules. If an arm64 binary is not available for the target node version, it's logged but ignored. arm64 is not expected to work in very old node.lib distribution formats, the test URLs in these cases are added to be consistent with x64. PR-URL: #1875 Reviewed-By: João Reis <reis@janeasystems.com>
Hi, I am trying to build my Electron app for Windows 10 on ARM, but this issue is preventing me from doing so. Firstly, I don't have a Could you please point me towards the right file for ARM64 and where it should be placed for the ARM64 compilation to work as expected? |
They are way too lazy to document things down. |
I keep getting an 404 using node-gyp:
How can I instruct gyp to use the unofficial-builds? |
Try setting |
(As an aside https://github.com/EwoutH/Signal-Desktop/runs/1749166864?check_suite_focus=true#step:9:44 shows that the x64 version of Node.js is being run which is why it's looking in |
NodeJS now officially support Windows ARM64 platform, can we reconsider this issue? |
Checklist
npm install && npm test
passesDescription of change
Windows on Arm support is available in some versions of Node.js v12 and Electron v6. This update allows node-gyp to fetch the appropriate node.lib to build native modules. If an arm64 binary is not available for the target node version, it's logged but ignored.
arm64 is not expected to work in very old node.lib distribution formats, the test URLs in these cases are added to be consistent with x64.