This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Make autocompletion in REPL work #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in `internal/inspect_repl.js` that caused REPL to crash when trying to invoke autocomplete. Steps to reproduce: * Start the debugger. * Run `repl` command. * Type any letter. * Press <Tab>. * Debugger crashes with `TypeError: elem.indexOf is not a function`. The reason is that Node's REPL expects a completion group to be an array of strings while node-inspect passed an instance of ScopeSnapshot. This commit fixes it by adding completion groups for REPL as properties of ScopeSnapshot instances and returning them when evaluating ".scope".
|
Thanks & sorry for the delay. Tested locally & verified. Not sure myself if our current test setup allows sending CI run: https://ci.nodejs.org/view/x%20-%20Diagnostics/job/node-inspect-continuous-integration/13/ |
jkrems
changed the title
|
CI passes apart from the windows failures we're seeing on master as well. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in
internal/inspect_repl.jsthat caused REPL to crashwhen trying to invoke autocomplete. Steps to reproduce:
replcommand.TypeError: elem.indexOf is not a function.The reason is that Node's REPL expects a completion group to be an
array of strings while node-inspect passed an instance of ScopeSnapshot.
This commit fixes it by adding completion groups for REPL as properties
of ScopeSnapshot instances and returning them when evaluating ".scope".