deps: Add node-inspect 1.10.6 #11869

jkrems · 2017-03-15T18:19:10Z

This updates the bundled node-inspect to 1.10.6.

Highlights

node --debug-port=1234 inspect respects the custom port.
Test stability improvements on various platforms.

Compare: nodejs/node-inspect@v1.10.4...v1.10.6

Rendered Changelog

1.10.6

chore: Fix usage text for embedded mode - @addaleax #20

b0779f5 chore: Fix usage text for embedded mode

print 'ok' after connection - @ofrobots #25

2a47125 fix: print 'ok' after connection

Make autocompletion in REPL work - @aqrln #28

ccab737 fix: Make autocompletion in REPL work

Remove console.error() statement - @aqrln #30

032b045 style: Remove console.error() statement

Take --debug-port into account - @jkrems #26

054d4b1 fix: Take --debug-port into account

Delay run until breakpoints are restored - @jkrems #34

802b88c fix: Delay run until breakpoints are restored

2b93173 fix: Use single string for paused notice

b4d5ee2 fix: Work around inconsistent handling of strict directive

f6ccfc7 fix: Only restart after port is free

8b101bf test: Skip exact match on AIX

a4e4b6f chore: Fix repo info in package.json

1.10.5

docs: minor edits to governance docs - @joshgav #17

a70fe04 docs: minor edits to governance docs

Checklist

make test-node-inspect passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

node-inspect

This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6

jkrems · 2017-03-15T18:20:57Z

Previous PR: #10187

Changeset generated via:

rm -rf deps/node-inspect node-inspect-* && curl -sSL "https://github.com/nodejs/node-inspect/archive/v1.10.6.tar.gz" | tar -xzvf - && mv node-inspect-* deps/node-inspect

jkrems · 2017-03-15T19:40:51Z

One test fails because of https://github.com/nodejs/node/pull/6171/files#r106263519 - <enter> is swallowed inside of repl.

jkrems · 2017-03-15T20:15:01Z

lib/internal/bootstrap_node.js

@@ -81,7 +81,9 @@

    } else if (process.argv[1] === 'inspect') {
      // Start the debugger agent
-      NativeModule.require('node-inspect/lib/_inspect').start();
+      process.nextTick(function() {


This hack appear in multiple places in bootstrap. What I saw before adding it: The pingPort function calls net.connect and setTimeout. Unless the latter was removed or moved to the next tick, none of the connect events would ever fire.

addaleax

Rubber-stamp-ish LGTM (lib: might be a better subsystem for the second commit, though)

CI: https://ci.nodejs.org/job/node-test-commit/8488/

jkrems · 2017-03-15T22:42:09Z

s/deps:/lib: for that second commit message. Guess I went with deps: because I was still thinking about merging the two commits while writing the commit message. Thanks for clarifying! 👍

jkrems · 2017-03-15T22:45:23Z

Since make test-node-inspect doesn't pass on master right now, I backed that bullet point out of the issue description (working on making them pass again in parallel).

Trott

Rubber-stamp LGTM if CI is ✅

jasnell

Rubber stamp LGTM here as well. Tried it out and it appears to work as expected :-)

jkrems · 2017-03-16T17:27:58Z

I think my force-push to reword the commit is why those CI builds failed (Could not checkout 7f0e8337eaf1198a9f23a2de25d2b9418800f84e).

jasnell · 2017-03-17T16:04:59Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/6901/

jkrems · 2017-03-17T17:39:46Z

🍏

This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6 PR-URL: #11869 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #11869 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell · 2017-03-17T17:51:09Z

Landed in b57f9ee...7042631

PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6 PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: nodejs#11869 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Notable changes: * deps: Add node-inspect 1.10.6 (Jan Krems) #11869 * inspector: proper WS URLs when bound to 0.0.0.0 (Eugene Ostroukhov) #11850 * tls: fix segfault on destroy after partial read. (Ben Noordhuis) #11898 PR-URL: #11941

deps: Add node-inspect 1.10.6

c3ded73

This updates the bundled `node-inspect` to 1.10.6. Highlights: * `node --debug-port=1234 inspect` respects the custom port. * Test stability improvements on various platforms. Compare: nodejs/node-inspect@v1.10.4...v1.10.6

mscdex added the debugger label Mar 15, 2017

jkrems commented Mar 15, 2017

View reviewed changes

addaleax approved these changes Mar 15, 2017

View reviewed changes

lib: Fix swallowed events in inspect integration

43bd1db

jkrems force-pushed the node-inspect-1.10.6 branch from 7f0e833 to 43bd1db Compare March 15, 2017 22:41

Trott approved these changes Mar 16, 2017

View reviewed changes

jasnell approved these changes Mar 16, 2017

View reviewed changes

cjihrig approved these changes Mar 16, 2017

View reviewed changes

jasnell closed this Mar 17, 2017

jkrems deleted the node-inspect-1.10.6 branch March 17, 2017 18:09

italoacasas mentioned this pull request Mar 20, 2017

v7.7.4 Release Proposal #11941

Merged

aliscco mentioned this pull request Dec 1, 2023

[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#962

Open

leonardoadame mentioned this pull request Dec 1, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#377

Open

This was referenced Dec 1, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 aliscco/alisco-node#966

Open

[Snyk] Security upgrade eslint from 4.18.2 to 6.0.0 aliscco/alisco-node#968

Open

This was referenced Dec 1, 2023

[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 leonardoadame/node#391

Open

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#397

Open

This was referenced Dec 1, 2023

[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1001

Open

[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 aliscco/alisco-node#1012

Open

adamlaska mentioned this pull request Dec 2, 2023

[Snyk] Fix for 1 vulnerabilities adamlaska/node#132

Open

aliscco mentioned this pull request Dec 2, 2023

[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1015

Open

leonardoadame mentioned this pull request Dec 2, 2023

[Snyk] Security upgrade eslint from 5.16.0 to 6.0.0 leonardoadame/node#426

Open

leonardoadame mentioned this pull request Dec 2, 2023

[Snyk] Security upgrade eslint from 4.12.1 to 6.0.0 leonardoadame/node#445

Open

This was referenced Dec 2, 2023

[Snyk] Security upgrade eslint from 2.13.1 to 6.0.0 aliscco/alisco-node#1040

Open

[Snyk] Fix for 6 vulnerabilities aliscco/alisco-node#1050

Open

[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1053

Open

This was referenced Dec 2, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#453

Open

[Snyk] Security upgrade eslint from 5.7.0 to 6.0.0 leonardoadame/node#455

Open

This was referenced Dec 2, 2023

[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#1066

Open

[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 aliscco/alisco-node#1067

Open

This was referenced Dec 3, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#477

Open

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#478

Open

[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 leonardoadame/node#493

Open

aliscco mentioned this pull request Dec 3, 2023

[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#1097

Open

leonardoadame mentioned this pull request Dec 3, 2023

[Snyk] Security upgrade eslint from 4.18.2 to 6.0.0 leonardoadame/node#505

Open

aliscco mentioned this pull request Dec 3, 2023

[Snyk] Security upgrade eslint from 5.16.0 to 6.0.0 aliscco/alisco-node#1124

Open

leonardoadame mentioned this pull request Dec 5, 2023

[Snyk] Fix for 1 vulnerabilities leonardoadame/node#543

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: Add node-inspect 1.10.6 #11869

deps: Add node-inspect 1.10.6 #11869

jkrems commented Mar 15, 2017 •

edited

Loading

jkrems commented Mar 15, 2017

jkrems commented Mar 15, 2017

jkrems Mar 15, 2017

addaleax left a comment

jkrems commented Mar 15, 2017 •

edited

Loading

jkrems commented Mar 15, 2017

Trott left a comment •

edited

Loading

jasnell left a comment

jkrems commented Mar 16, 2017

jasnell commented Mar 17, 2017

jkrems commented Mar 17, 2017

jasnell commented Mar 17, 2017

deps: Add node-inspect 1.10.6 #11869

deps: Add node-inspect 1.10.6 #11869

Conversation

jkrems commented Mar 15, 2017 • edited Loading

Highlights

Rendered Changelog

1.10.6

1.10.5

Checklist

Affected core subsystem(s)

jkrems commented Mar 15, 2017

jkrems commented Mar 15, 2017

jkrems Mar 15, 2017

Choose a reason for hiding this comment

addaleax left a comment

Choose a reason for hiding this comment

jkrems commented Mar 15, 2017 • edited Loading

jkrems commented Mar 15, 2017

Trott left a comment • edited Loading

Choose a reason for hiding this comment

jasnell left a comment

Choose a reason for hiding this comment

jkrems commented Mar 16, 2017

jasnell commented Mar 17, 2017

jkrems commented Mar 17, 2017

jasnell commented Mar 17, 2017

jkrems commented Mar 15, 2017 •

edited

Loading

jkrems commented Mar 15, 2017 •

edited

Loading

Trott left a comment •

edited

Loading