Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

dns.resolveTxt segfault #9285

Closed
maxtaco opened this issue Feb 25, 2015 · 1 comment
Closed

dns.resolveTxt segfault #9285

maxtaco opened this issue Feb 25, 2015 · 1 comment

Comments

@maxtaco
Copy link

maxtaco commented Feb 25, 2015

To reproduce, run:

var dns = require('dns');
dns.resolveTxt('www.ralphrooding.com', function(err, res) {})

Node version is v0.12.0

First reported here: keybase/keybase-issues#1413
This was referenced Feb 25, 2015
Closed
Closed
@maxtaco maxtaco mentioned this issue Jun 1, 2015
Closed
jasnell pushed a commit that referenced this issue Aug 27, 2015
@evanlucas @jasnell
src: fix intermittent SIGSEGV in resolveTxt
261fa36 
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting
it on `txt_records`

Fixes: #9285
PR-URL: #9300
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
@iankronquist
Copy link

I was sent here by code triage.
This issue appears to have been fixed for node 0.12.8 and above. See commit 261fa36 which references this issue. I recommend that it be closed.

jBarz pushed a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
@evanlucas @jBarz
src: fix intermittent SIGSEGV in resolveTxt
655fbb9 
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting
it on `txt_records`

Fixes: nodejs#9285
PR-URL: nodejs#9300
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bnoordhuis @maxtaco @iankronquist