Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix intermittent SIGSEGV in resolveTxt #960

Closed
wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Contributor

Fixes a SIGSEGV by making sure txt_chunk is not empty before setting
it on txt_records

Ref: nodejs/node-v0.x-archive#9285

@rvagg
Copy link
Member

rvagg commented Feb 25, 2015

Are we upstreaming these or are we giving up on working with c-ares?

@rvagg
Copy link
Member

rvagg commented Feb 25, 2015

Oh, sorry, this is the wrap. Ignore that comment then!

LGTM and we can get this in 1.4.0.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 26, 2015

The following code reproduces the error with a well known site. Do you think it's worth adding this to the internet test suite?

var dns = require('dns');

dns.resolveTxt('www.microsoft.com', function(err, res) {
   console.log(err);
   console.log(res);
});

@rvagg
Copy link
Member

rvagg commented Feb 26, 2015

@cjihrig probably .. it's simple enough and should probably go in test/internet

@evanlucas
Copy link
Contributor Author

k, ill add that

Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting
it on `txt_records`
@evanlucas
Copy link
Contributor Author

Test has been added

@rvagg
Copy link
Member

rvagg commented Feb 26, 2015

lgtm, land it

evanlucas added a commit that referenced this pull request Feb 26, 2015
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting
it on `txt_records`

PR-URL: #960
Reviewed-By: Rod Vagg <rod@vagg.org>
@evanlucas
Copy link
Contributor Author

Landed in e435a01

@evanlucas evanlucas closed this Feb 26, 2015
@evanlucas evanlucas deleted the dns-txt-fix branch February 26, 2015 04:48
@rvagg rvagg mentioned this pull request Feb 26, 2015
evanlucas added a commit to evanlucas/node-v0.x-archive that referenced this pull request Feb 26, 2015
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting
it on `txt_records`

PR-URL: nodejs/node#960
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants