cli: support --experimental-top-level-await in NODE_OPTIONS

PR-URL: #33495 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs · Jun 18, 2020 · 22b5ec1 · 22b5ec1
1 parent 011fe1d
commit 22b5ec1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -1185,6 +1185,7 @@ Node.js options that are allowed are:
 * `--experimental-policy`
 * `--experimental-repl-await`
 * `--experimental-specifier-resolution`
+* `--experimental-top-level-await`
 * `--experimental-vm-modules`
 * `--experimental-wasi-unstable-preview1`
 * `--experimental-wasm-modules`

diff --git a/src/node_options.cc b/src/node_options.cc
@@ -599,7 +599,8 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
 
   AddOption("--experimental-top-level-await",
             "enable experimental support for ECMAScript Top-Level Await",
-            &PerIsolateOptions::experimental_top_level_await);
+            &PerIsolateOptions::experimental_top_level_await,
+            kAllowedInEnvironment);
   AddOption("--harmony-top-level-await", "", V8Option{});
   Implies("--experimental-top-level-await", "--harmony-top-level-await");
   Implies("--harmony-top-level-await", "--experimental-top-level-await");

diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
@@ -78,6 +78,10 @@ expect('--stack-trace-limit=100',
 if (!['arm', 'arm64', 's390x'].includes(process.arch))
   expect('--interpreted-frames-native-stack', 'B\n');
 
+// Workers can't eval as ES Modules. https://github.com/nodejs/node/issues/30682
+expectNoWorker('--experimental-top-level-await --input-type=module',
+               'B\n', 'console.log(await "B")');
+
 function expectNoWorker(opt, want, command, wantsError) {
   expect(opt, want, command, wantsError, false);
 }