Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: support --experimental-top-level-await in NODE_OPTIONS #33495

Closed
wants to merge 1 commit into from
Closed

cli: support --experimental-top-level-await in NODE_OPTIONS #33495

wants to merge 1 commit into from

Conversation

dfabulich
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 21, 2020
@dfabulich dfabulich mentioned this pull request May 21, 2020
Closed
2 tasks
BridgeAR
BridgeAR reviewed May 21, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test in test/parallel/test-cli-node-options.js

@devsnek
Copy link
Member

devsnek commented May 21, 2020

it is weird to me that we allow experimental options in the env

@dfabulich
Copy link
Contributor Author

Test added. Note that this test won't verify --experimental-top-level-await in a worker thread, because the test uses eval on the worker, and there's no way to make a worker that will eval ESM. #30682

@dfabulich
Copy link
Contributor Author

I think this PR should be author ready?

@BridgeAR
Copy link
Member

@dfabulich a PR is considered author-ready when the CI started and at least one collaborator gave a LG while there are no open comments. The CI was missing and it's mainly an internal label to know when things are ready to land.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31481/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2020
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 23, 2020
@dfabulich @BridgeAR
cli: support --experimental-top-level-await in NODE_OPTIONS
842a895 
PR-URL: nodejs#33495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR
Copy link
Member

Landed in 842a895 🎉

@BridgeAR BridgeAR closed this May 23, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@dfabulich @codebytere
cli: support --experimental-top-level-await in NODE_OPTIONS
5bd357b 
PR-URL: #33495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@dfabulich @codebytere
cli: support --experimental-top-level-await in NODE_OPTIONS
22b5ec1 
PR-URL: #33495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@dfabulich @codebytere
cli: support --experimental-top-level-await in NODE_OPTIONS
53e29e4 
PR-URL: #33495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dfabulich @devsnek @BridgeAR @nodejs-github-bot @targos @cjihrig @codebytere