-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Mention --experimental-top-level-await flag #33473
Conversation
I don't want to be against this change, but is it currently documented here |
I didn't mean to say that it's not documented, but the changelog should mention that it's behind the flag, I think. |
this will also require a change to https://github.com/nodejs/nodejs.org/blob/master/locale/en/blog/release/v14.3.0.md |
I filed a separate PR for nodejs.org. |
The changelog does not mention that it's behind a flag if it needs to be, so it's confusing. |
@dfabulich it is also not specified in the cli doc |
Good catch! I added documentation to |
While updating |
These tests were passing before I added that whitespace change; I'm about 99% sure this is a flaky build issue. (I don't see any way to rerun the build myself.) |
26ca8c3
to
dfaa01b
Compare
I'm about 99.999% sure this documentation PR didn't cause this failing test.
|
@dfabulich we have multiple flaky tests. It is some times difficult to get the tests passing consistently on the amount of different systems and settings we support. If you stumble upon one of those, you might want to check if there's a corresponding issue and if not, to open a new issue for the failure. |
PR-URL: nodejs#33473 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in c39467c 🎉 |
PR-URL: #33473 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #33473 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #33473 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist