Skip to content

Commit

Permalink
src: update NODE_MODULE_VERSION to 115
Browse files Browse the repository at this point in the history
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 11.3.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
  • Loading branch information
targos authored and nodejs-github-bot committed Mar 31, 2023
1 parent ab1614d commit 295b2f3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions doc/abi_version_registry.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
{
"NODE_MODULE_VERSION": [
{ "modules": 114,"runtime": "electron", "variant": "electron", "versions": "24" },
{ "modules": 113,"runtime": "electron", "variant": "electron", "versions": "23" },
{ "modules": 112, "runtime": "node", "variant": "v8_10.9", "versions": "20.0.0-pre" },
{ "modules": 115,"runtime": "node", "variant": "v8_11.2", "versions": "20.0.0-pre" },
{ "modules": 114,"runtime": "electron", "variant": "electron", "versions": "24" },
{ "modules": 113,"runtime": "electron", "variant": "electron", "versions": "23" },
{ "modules": 112,"runtime": "node", "variant": "v8_10.9", "versions": "20.0.0-pre" },
{ "modules": 111,"runtime": "node", "variant": "v8_10.7", "versions": "19.0.0" },
{ "modules": 110,"runtime": "electron", "variant": "electron", "versions": "22" },
{ "modules": 109,"runtime": "electron", "variant": "electron", "versions": "21" },
Expand Down
2 changes: 1 addition & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
* version matching should open a pull request to reserve a number in this
* registry.
*/
#define NODE_MODULE_VERSION 112
#define NODE_MODULE_VERSION 115

// The NAPI_VERSION provided by this version of the runtime. This is the version
// which the Node binary being built supports.
Expand Down

0 comments on commit 295b2f3

Please sign in to comment.