-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: dgram socket prints deprecation warnings
Adds tests assert the deprecated properties and methods in the dgram socket warn. It runs each test in a separate child process since each deprecation will only warn once. PR-URL: #24177 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
- Loading branch information
1 parent
f697457
commit 368789f
Showing
1 changed file
with
84 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
'use strict'; | ||
|
||
const assert = require('assert'); | ||
const common = require('../common'); | ||
const dgram = require('dgram'); | ||
const fork = require('child_process').fork; | ||
|
||
const sock = dgram.createSocket('udp4'); | ||
|
||
const testNumber = parseInt(process.argv[2], 10); | ||
|
||
const propertiesToTest = [ | ||
'_handle', | ||
'_receiving', | ||
'_bindState', | ||
'_queue', | ||
'_reuseAddr' | ||
]; | ||
|
||
const methodsToTest = [ | ||
'_healthCheck', | ||
'_stopReceiving' | ||
]; | ||
|
||
const propertyCases = propertiesToTest.map((propName) => { | ||
return [ | ||
() => { | ||
// Test property getter | ||
common.expectWarning( | ||
'DeprecationWarning', | ||
`Socket.prototype.${propName} is deprecated`, | ||
'DEP0112' | ||
); | ||
sock[propName]; | ||
}, | ||
() => { | ||
// Test property setter | ||
common.expectWarning( | ||
'DeprecationWarning', | ||
`Socket.prototype.${propName} is deprecated`, | ||
'DEP0112' | ||
); | ||
sock[propName] = null; | ||
} | ||
]; | ||
}); | ||
|
||
const methodCases = methodsToTest.map((propName) => { | ||
return () => { | ||
common.expectWarning( | ||
'DeprecationWarning', | ||
`Socket.prototype.${propName}() is deprecated`, | ||
'DEP0112' | ||
); | ||
sock[propName](); | ||
}; | ||
}); | ||
|
||
const cases = [].concat( | ||
...propertyCases, | ||
...methodCases | ||
); | ||
|
||
// If we weren't passed a test ID then we need to spawn all of the cases. | ||
// We run the cases in child processes since deprecations print once. | ||
if (Number.isNaN(testNumber)) { | ||
const children = cases.map((_case, i) => | ||
fork(process.argv[1], [ String(i) ])); | ||
|
||
children.forEach((child) => { | ||
child.on('close', (code) => { | ||
// Pass on child exit code | ||
if (code > 0) { | ||
process.exit(code); | ||
} | ||
}); | ||
}); | ||
|
||
return; | ||
} | ||
|
||
// We were passed a test ID - run the test case | ||
assert.ok(cases[testNumber]); | ||
cases[testNumber](); |