Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test dgram socket prints deprecation warnings #24177

Closed
wants to merge 1 commit into from

Conversation

rpamely
Copy link
Contributor

@rpamely rpamely commented Nov 6, 2018

Adds tests assert the deprecated properties
and methods in the dgram socket warn. It
runs each test in a separate child process
since each deprecation will only warn once.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Adds tests assert the deprecated properties
and methods in the dgram socket warn. It
runs each test in a separate child process
since each deprecation will only warn once.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@addaleax addaleax added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. labels Nov 6, 2018
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@rpamely
Copy link
Contributor Author

rpamely commented Nov 7, 2018

Thanks @BridgeAR! These linter build failures seem unrelated to my PR. Any idea what's going on here?

@gireeshpunathil
Copy link
Member

@gireeshpunathil
Copy link
Member

landed as 368789f

thank you @rpamely for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

gireeshpunathil pushed a commit that referenced this pull request Nov 12, 2018
Adds tests assert the deprecated properties
and methods in the dgram socket warn. It
runs each test in a separate child process
since each deprecation will only warn once.

PR-URL: #24177
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
Adds tests assert the deprecated properties
and methods in the dgram socket warn. It
runs each test in a separate child process
since each deprecation will only warn once.

PR-URL: #24177
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
Adds tests assert the deprecated properties
and methods in the dgram socket warn. It
runs each test in a separate child process
since each deprecation will only warn once.

PR-URL: nodejs#24177
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants