-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http2: check write not scheduled in scope destructor
Fixes: #33156 PR-URL: #36241 Backport-PR-URL: #36372 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
- Loading branch information
1 parent
c44b478
commit 4b315a5
Showing
2 changed files
with
48 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
'use strict'; | ||
// https://github.com/nodejs/node/issues/33156 | ||
const common = require('../common'); | ||
const fixtures = require('../common/fixtures'); | ||
|
||
if (!common.hasCrypto) { | ||
common.skip('missing crypto'); | ||
} | ||
|
||
const http2 = require('http2'); | ||
|
||
const key = fixtures.readKey('agent8-key.pem', 'binary'); | ||
const cert = fixtures.readKey('agent8-cert.pem', 'binary'); | ||
const ca = fixtures.readKey('fake-startcom-root-cert.pem', 'binary'); | ||
|
||
const server = http2.createSecureServer({ | ||
key, | ||
cert, | ||
maxSessionMemory: 1000 | ||
}); | ||
|
||
let client_stream; | ||
|
||
server.on('session', common.mustCall(function(session) { | ||
session.on('stream', common.mustCall(function(stream) { | ||
stream.resume(); | ||
stream.on('data', function() { | ||
this.write(Buffer.alloc(1)); | ||
process.nextTick(() => client_stream.destroy()); | ||
}); | ||
})); | ||
})); | ||
|
||
server.listen(0, function() { | ||
const client = http2.connect(`https://localhost:${server.address().port}`, { | ||
ca, | ||
maxSessionMemory: 1000 | ||
}); | ||
client_stream = client.request({ ':method': 'POST' }); | ||
client_stream.on('close', common.mustCall(() => { | ||
client.close(); | ||
server.close(); | ||
})); | ||
client_stream.resume(); | ||
client_stream.write(Buffer.alloc(64 * 1024)); | ||
}); |