-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v14.x backport] http2: check write not scheduled in scope destructor #36372
[v14.x backport] http2: check write not scheduled in scope destructor #36372
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CI: https://ci.nodejs.org/job/node-test-pull-request/34884/ |
Last CI is good (osx failure appears to be due to nodejs/build#2482). The original PR #36241 hasn't been in current for 2 weeks - could anyone from @nodejs/http2 give this a review and advise whether you feel it should land in v14.x without the wait? |
I would include it. |
3168ac1
to
c44b478
Compare
Landed in 4b315a5 |
Fixes: #33156
PR-URL: #36241
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes