src: fix unhandled error in structuredClone

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #54764 Fixes: #54602 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Sep 12, 2024 · 97cbcfb · 97cbcfb
1 parent 608a611
commit 97cbcfb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/node_messaging.cc b/src/node_messaging.cc
@@ -566,7 +566,9 @@ Maybe<bool> Message::Serialize(Environment* env,
     if (host_object &&
         host_object->GetTransferMode() == TransferMode::kTransferable) {
       delegate.AddHostObject(host_object);
-      continue;
+    } else {
+      ThrowDataCloneException(context, env->clone_untransferable_str());
+      return Nothing<bool>();
     }
   }
   if (delegate.AddNestedHostObjects().IsNothing())

diff --git a/test/parallel/test-structuredClone-global.js b/test/parallel/test-structuredClone-global.js
@@ -26,3 +26,6 @@ assert.strictEqual(structuredClone(undefined, { }), undefined);
 
   assert.deepStrictEqual(cloned, {});
 }
+
+const blob = new Blob();
+assert.throws(() => structuredClone(blob, { transfer: [blob] }), { name: 'DataCloneError' });