src: fix unhandled error in structuredClone #54764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54764 +/- ##
=======================================
Coverage 87.61% 87.61%
=======================================
Files 650 650
Lines 182829 182831 +2
Branches 35382 35378 -4
=======================================
+ Hits 160179 160195 +16
+ Misses 15931 15916 -15
- Partials 6719 6720 +1
|
anonrig
approved these changes
Sep 5, 2024
daeyeon
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Sep 7, 2024
jasnell
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eab9729 |
Merged
targos
added
the
dont-land-on-v20.x
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: nodejs#54764 Fixes: nodejs#54602 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #54602
This patch adds error handling in
structuredClonefor objects set as cloneable but untransferable viamarkTransferMode(this, true, false). As a result, it ensures that a DataCloneError is thrown when cloning a Blob with the transfer option.Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com