src: remove extra ReadStop() call

This is no longer necessary since libuv 1.21.0. PR-URL: #21528 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Jun 30, 2018 · a078521 · a078521
1 parent deff8db
commit a078521
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/src/stream_wrap.cc b/src/stream_wrap.cc
@@ -373,11 +373,6 @@ void LibuvStreamWrap::AfterUvWrite(uv_write_t* req, int status) {
   req_wrap->Done(status);
 }
 
-void LibuvStreamWrap::Close(v8::Local<v8::Value> close_callback) {
-  ReadStop();
-  HandleWrap::Close(close_callback);
-}
-
 }  // namespace node
 
 NODE_BUILTIN_MODULE_CONTEXT_AWARE(stream_wrap,

diff --git a/src/stream_wrap.h b/src/stream_wrap.h
@@ -76,8 +76,6 @@ class LibuvStreamWrap : public HandleWrap, public StreamBase {
   ShutdownWrap* CreateShutdownWrap(v8::Local<v8::Object> object) override;
   WriteWrap* CreateWriteWrap(v8::Local<v8::Object> object) override;
 
-  void Close(v8::Local<v8::Value> close_callback) override;
-
  protected:
   LibuvStreamWrap(Environment* env,
                   v8::Local<v8::Object> object,