Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove extra ReadStop() call #21528

Closed
wants to merge 1 commit into from
Closed

src: remove extra ReadStop() call #21528

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jun 25, 2018 •
edited
Loading

This is no longer necessary since libuv 1.21.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-commit/19444/

(Only failure is #21038 and the automatically started re-run is clear on LinuxOne)

@addaleax
src: remove extra ReadStop() call
7b17741 
This is no longer necessary since libuv 1.21.0.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/155/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 25, 2018
@addaleax addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 25, 2018
@addaleax
Copy link
Member Author

Landed in a078521

@addaleax addaleax closed this Jun 30, 2018
@addaleax addaleax deleted the remove-extra-read-stop branch June 30, 2018 13:52
addaleax added a commit that referenced this pull request Jun 30, 2018
@addaleax
src: remove extra ReadStop() call
a078521 
This is no longer necessary since libuv 1.21.0.

PR-URL: #21528
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 3, 2018
@addaleax @targos
src: remove extra ReadStop() call
a8a7575 
This is no longer necessary since libuv 1.21.0.

PR-URL: #21528
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
@bzoz bzoz mentioned this pull request Sep 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig @devsnek