test_runner: fix invalid timer call

Signed-off-by: Erick Wendel <erick.workspace@gmail.com> PR-URL: #49477 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
nodejs · Nov 27, 2023 · ba57c24 · ba57c24
1 parent 5949ae0
commit ba57c24
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 16 deletions.
diff --git a/lib/internal/test_runner/mock/mock_timers.js b/lib/internal/test_runner/mock/mock_timers.js
@@ -371,7 +371,7 @@ class MockTimers {
     ObjectDefineProperty(
       nodeTimers,
       'setTimeout',
-      this.#realSetTimeout,
+      this.#realTimersSetTimeout,
     );
     ObjectDefineProperty(
       nodeTimers,

diff --git a/test/parallel/test-runner-mock-timers.js b/test/parallel/test-runner-mock-timers.js
@@ -46,8 +46,7 @@ describe('Mock Timers Test Suite', () => {
         code: 'ERR_INVALID_ARG_VALUE',
       });
     });
-
-    it('should check that propertyDescriptor gets back after reseting timers', (t) => {
+    it('should check that propertyDescriptor gets back after resetting timers', (t) => {
       const getDescriptor = (ctx, fn) => Object.getOwnPropertyDescriptor(ctx, fn);
       const getCurrentTimersDescriptors = () => {
         const timers = [
@@ -71,26 +70,36 @@ describe('Mock Timers Test Suite', () => {
           nodeTimersPromises: nodeTimersPromisesDescriptors,
         };
       };
-      const before = getCurrentTimersDescriptors();
+
+      const originalDescriptors = getCurrentTimersDescriptors();
+
       t.mock.timers.enable();
       const during = getCurrentTimersDescriptors();
       t.mock.timers.reset();
       const after = getCurrentTimersDescriptors();
 
-      assert.deepStrictEqual(
-        before,
-        after,
-      );
+      for (const env in originalDescriptors) {
+        for (const prop in originalDescriptors[env]) {
+          const originalDescriptor = originalDescriptors[env][prop];
+          const afterDescriptor = after[env][prop];
 
-      assert.notDeepStrictEqual(
-        before,
-        during,
-      );
+          assert.deepStrictEqual(
+            originalDescriptor,
+            afterDescriptor,
+          );
 
-      assert.notDeepStrictEqual(
-        during,
-        after,
-      );
+          assert.notDeepStrictEqual(
+            originalDescriptor,
+            during[env][prop],
+          );
+
+          assert.notDeepStrictEqual(
+            during[env][prop],
+            after[env][prop],
+          );
+
+        }
+      }
     });
 
     it('should reset all timers when calling .reset function', (t) => {