Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix invalid timer call #49477

Merged
merged 2 commits into from
Sep 5, 2023
Merged

test_runner: fix invalid timer call #49477

merged 2 commits into from
Sep 5, 2023

Conversation

ErickWendel
Copy link
Member

fix missing call to reset node timer call

@ErickWendel
test_runner: fix invalid timer call
72220bf 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 3, 2023
rluvaton
rluvaton reviewed Sep 3, 2023
View reviewed changes
Copy link
Member

@rluvaton rluvaton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a test?

@ErickWendel
test_runner: manually check descriptors
279aa99 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
@ErickWendel
Copy link
Member Author

can you please add a test?

there's a test but wasn't working as expected. I've changed it to the final impl

@atlowChemi atlowChemi added experimental Issues and PRs related to experimental features. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53710/

@atlowChemi atlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 4, 2023
@ErickWendel ErickWendel added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53712/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53718/

@ErickWendel ErickWendel added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023
@github-actions github-actions bot mentioned this pull request Sep 5, 2023
Open
19 tasks
@ErickWendel ErickWendel added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit a61bc9d into nodejs:main Sep 5, 2023
39 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a61bc9d

This was referenced Sep 6, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@ErickWendel @ruyadorno
test_runner: fix invalid timer call
b4d42a8 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: #49477
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
Closed
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@ErickWendel @alexfernandez
test_runner: fix invalid timer call
6b91bfe 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: nodejs#49477
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Nov 27, 2023
@ErickWendel @targos
test_runner: fix invalid timer call
ba57c24 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: #49477
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix invalid timer call
78dc39f 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: nodejs/node#49477
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix invalid timer call
52f6c1a 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: nodejs/node#49477
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluvaton rluvaton rluvaton left review comments

@atlowChemi atlowChemi atlowChemi approved these changes

@MoLow MoLow MoLow approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ErickWendel @nodejs-github-bot @benjamingr @MoLow @rluvaton @atlowChemi