Skip to content

Commit

Permalink
doc: make writable.setDefaultEncoding() return this
Browse files Browse the repository at this point in the history
Let this function return `this` for parity with `readable.setEncoding()`.

PR-URL: #5040
Fixes: #5013

Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
estliberitas authored and calvinmetcalf committed Apr 30, 2016
1 parent 62c31fe commit bcce05d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions doc/api/stream.md
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,7 @@ file.end('world!');
#### writable.setDefaultEncoding(encoding)

* `encoding` {String} The new default encoding
* Return: `this`

Sets the default encoding for a writable stream.

Expand Down
1 change: 1 addition & 0 deletions lib/_stream_writable.js
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ Writable.prototype.setDefaultEncoding = function setDefaultEncoding(encoding) {
if (!Buffer.isEncoding(encoding))
throw new TypeError('Unknown encoding: ' + encoding);
this._writableState.defaultEncoding = encoding;
return this;
};

function decodeChunk(state, chunk, encoding) {
Expand Down

2 comments on commit bcce05d

@Fishrock123
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have been stream:

@calvinmetcalf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad

Please sign in to comment.