Tracking Issue: Migrate errors to internal/errors.js #11273

jasnell · 2017-02-09T21:58:17Z

Now that #11220 has landed, we need to begin the process of migrating errors in the */lib.js source over to use it. A basic guide is provided here.

Note that moving existing errors over to this mechanism should, in general, be considered semver-major.

Please use the following list to track which files have been migrated over to using the new errors and provide a link back to this issue in the relevant PRs

`stream` related (blocked)

_{@refack: removed GFC label and commented out sentence in description + split off stream stuff}
_{@BridgeAR: updated the list}

The text was updated successfully, but these errors were encountered:

fl0w · 2017-02-10T03:46:52Z

Am I wrong in thinking this could be a "good first contribution"? Would love to give it a try in that case.
Also, I'm assuming */lib.js is a typo for lib/*.js?

joyeecheung · 2017-02-10T07:47:39Z

I think this could be a good first contribution in general, though some of the errors could be more complicated(the ones that are more frequently getting parsed in userland).

Also, I'm assuming /lib.js is a typo for lib/.js?

Probably lib/**/*.js :)

joyeecheung · 2017-02-10T07:54:23Z

@jasnell I've added links to those files, hope I am doing this right..

jasnell · 2017-02-10T17:02:14Z

@fl0w ... yes, this can be a good first contribution. Please use my PR #11294 as a model. New error codes are added to internal/errors.js. Please reuse existing codes as possible. For instance, my PR #11294 introduces the ERR_INVALID_ARG_TYPE error code. If you're going through and making changes before #11294 lands, and you need ERR_INVALID_ARG_TYPE, duplicate it from #11294 as a separate commit in your PR. Then, if #11294 lands first, you can rebase and drop that commit, but if your PR lands first, then I can rebase and drop it from mine, etc. (hopefully that makes sense).

Also please make sure that descriptions for the error codes are added to docs/api/errors.md the way I've illustrated in #11294.

Really appreciate your willingness to jump in! Let me know if you have any questions or issues!

seppevs · 2017-02-10T19:30:13Z

@jasnell: can we modify the error messages of existing errors to more generic and reusable error messages? Or should the error message be completely backwards compatible?

jasnell · 2017-02-10T19:51:49Z

Modifying the error message is certainly possible. The biggest thing is to avoid duplicating error codes so make sure you check the other PRs for codes that may be reusable.

Refs: nodejs#11273

joyeecheung · 2017-02-11T11:18:15Z

Do we need to launch CITGM for all these semver-major PRs? cc @nodejs/build

jasnell · 2017-02-11T13:52:37Z

We should, yes.

PR-URL: nodejs/node#14682 Refs: nodejs/node#11273 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR · 2017-09-23T03:52:12Z

I just updated the list in the original post to reflect our current state. A couple of entries that were unchecked are now checked and a few that originally had PRs do not have PRs and still have to be ported.

ramimoshe · 2017-09-23T05:07:21Z

I am on "querystring.js"

ramimoshe · 2017-09-23T05:46:09Z

Here's a PR for lib/querystring.js: #15565
Please add to the list. Thanks!

Covert lib/net.js over to using lib/internal/errors.js Ref: nodejs#11273 I have not addressed the cases that use errnoException(), for reasons described in nodejsGH-12926 - Replace thrown errors in lib/net.js with errors from lib/internal/errors. The ERR_INVALID_OPT_VALUE error have been used in the Server.prototype.listen() method after a discussion in Ref: nodejs#14782 - Update tests according to the above modifications

Covert lib/net.js over to using lib/internal/errors.js - Replace thrown errors in lib/net.js with errors from lib/internal/errors. The ERR_INVALID_OPT_VALUE error have been used in the Server.prototype.listen() method - Update tests according to the above modifications PR-URL: #14782 Refs: #11273 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Covert lib/net.js over to using lib/internal/errors.js - Replace thrown errors in lib/net.js with errors from lib/internal/errors. The ERR_INVALID_OPT_VALUE error have been used in the Server.prototype.listen() method - Update tests according to the above modifications PR-URL: nodejs/node#14782 Refs: nodejs/node#11273 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

`buffer.transcode` is still using raw TypeError. This change is to convert it to use internal/errors. Ref: nodejs#11273

`buffer.transcode` is still using raw TypeError. This change is to convert it to use internal/errors. Ref: #11273 PR-URL: #16352 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

`buffer.transcode` is still using raw TypeError. This change is to convert it to use internal/errors. Ref: nodejs/node#11273 PR-URL: nodejs/node#16352 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

BridgeAR · 2017-12-16T09:37:08Z

I am closing this as outdated. All regular JS errors got migrated but might need some more polishing here and there. There are a couple c++ errors that should be migrated but this was never tracked here.

joyeecheung · 2017-12-16T09:46:42Z

@BridgeAR There seems to be a few new old-style errors added in JS since this PR opened, searching new Error\(.+\) yields 23 results in the current master. We should probably open a new issue for that.

joyeecheung · 2019-03-31T04:36:15Z

I believe this issue is mostly done now except the punycode ones. I opened #27023 for that, so I am going to close this. Feel free to reopen if anyone thinks otherwise.

joyeecheung · 2019-03-31T04:37:07Z

Oops, did not realize it was closed. Sorry about the noise.

mscdex added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Feb 9, 2017

seppevs mentioned this issue Feb 10, 2017

https: use internal/errors.js #11293

Closed

2 tasks

jasnell mentioned this issue Feb 10, 2017

errors, process: port internal/process errors to internal/errors #11294

Closed

4 tasks

jasnell mentioned this issue Feb 10, 2017

errors: assign error code to bootstrap_node created error #11298

Closed

3 tasks

jasnell added the good first issue Issues that are suitable for first-time contributors. label Feb 10, 2017

joyeecheung mentioned this issue Feb 10, 2017

New error system in WHATWG URL implementation #11299

Closed

jasnell mentioned this issue Feb 10, 2017

errors, child_process: migrate to using internal/errors #11300

Closed

4 tasks

This was referenced Feb 10, 2017

internal/util: use internal/errors.js #11301

Closed

errors,net: change internal/net.js to use internal/errors.js #11302

Closed

slammayjammay added a commit to slammayjammay/node that referenced this issue Feb 11, 2017

errors, console: migrate to use internal/errors.js

af32dc2

Refs: nodejs#11273

slammayjammay mentioned this issue Feb 11, 2017

errors, console: migrate to use internal/errors.js #11308

Closed

4 tasks

gunar mentioned this issue Feb 12, 2017

errors: port internal/fs errors to internal/errors #11317

Merged

4 tasks

seppevs mentioned this issue Feb 12, 2017

errors, path: migrate to use internal/errors.js #11319

Closed

4 tasks

This was referenced Feb 13, 2017

errors: port internal/net errors to internal/errors #11338

Closed

Internal error #11339

Closed

mskec mentioned this issue Feb 13, 2017

errors: migrate lib/console #11340

Closed

4 tasks

bougarfaoui mentioned this issue Feb 13, 2017

errors: port internal/buffer errors to internal/errors #11341

Closed

4 tasks

no23reason mentioned this issue Feb 13, 2017

errors, repl: migrate to use internal/errors.js #11347

Closed

4 tasks

kreig303 mentioned this issue Sep 18, 2017

errors crypto : migrate errors to internal/errors.js #15452

Closed

4 tasks

ramimoshe mentioned this issue Sep 23, 2017

lib/querystring: convert to using internal/errors #15565

Merged

ramimoshe mentioned this issue Sep 25, 2017

lib/https: convert to using internal/errors #15603

Closed

starkwang mentioned this issue Oct 21, 2017

buffer: convert buffer.transcode to use internal/errors #16352

Closed

3 tasks

starkwang added a commit to starkwang/node that referenced this issue Oct 22, 2017

buffer: convert buffer.transcode to use internal/errors

0117db7

`buffer.transcode` is still using raw TypeError. This change is to convert it to use internal/errors. Ref: nodejs#11273

reviewher mentioned this issue Nov 13, 2017

node 9 loses error call site information in Buffer.concat #16994

Closed

BridgeAR closed this as completed Dec 16, 2017

joyeecheung mentioned this issue Dec 16, 2017

Tracking issue: Migrate errors to internal/errors.js #17709

Closed

6 tasks

MylesBorins mentioned this issue Feb 18, 2018

Initiative refactor nodejs/TSC#446

Closed

joyeecheung mentioned this issue Mar 31, 2019

errors in punycode.js: assign codes or leave them alone? #27023

Closed

joyeecheung reopened this Mar 31, 2019

joyeecheung closed this as completed Mar 31, 2019

hiroppy mentioned this issue Jul 15, 2019

chore: added type checking using comments webpack/webpack-dev-server#2107

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking Issue: Migrate errors to internal/errors.js #11273

Tracking Issue: Migrate errors to internal/errors.js #11273

jasnell commented Feb 9, 2017 •

edited by joyeecheung

Loading

fl0w commented Feb 10, 2017

joyeecheung commented Feb 10, 2017

joyeecheung commented Feb 10, 2017

jasnell commented Feb 10, 2017

seppevs commented Feb 10, 2017

jasnell commented Feb 10, 2017

joyeecheung commented Feb 11, 2017

jasnell commented Feb 11, 2017

BridgeAR commented Sep 23, 2017

ramimoshe commented Sep 23, 2017

ramimoshe commented Sep 23, 2017

BridgeAR commented Dec 16, 2017

joyeecheung commented Dec 16, 2017

joyeecheung commented Mar 31, 2019

joyeecheung commented Mar 31, 2019

Tracking Issue: Migrate errors to internal/errors.js #11273

Tracking Issue: Migrate errors to internal/errors.js #11273

Comments

jasnell commented Feb 9, 2017 • edited by joyeecheung Loading

stream related (blocked)

fl0w commented Feb 10, 2017

joyeecheung commented Feb 10, 2017

joyeecheung commented Feb 10, 2017

jasnell commented Feb 10, 2017

seppevs commented Feb 10, 2017

jasnell commented Feb 10, 2017

joyeecheung commented Feb 11, 2017

jasnell commented Feb 11, 2017

BridgeAR commented Sep 23, 2017

ramimoshe commented Sep 23, 2017

ramimoshe commented Sep 23, 2017

BridgeAR commented Dec 16, 2017

joyeecheung commented Dec 16, 2017

joyeecheung commented Mar 31, 2019

joyeecheung commented Mar 31, 2019

jasnell commented Feb 9, 2017 •

edited by joyeecheung

Loading

`stream` related (blocked)