AIX CI failure: pseudo-tty/test-stderr-stdout-handle-sigwinch #11541
Comments
gibfahn
added
aix
|
I still think ptys just don't work right on AIX |
|
Possibly related
cc/ @gireeshpunathil who has been looking at these other tests |
|
either that or TTYs don't work right on AIX maybe just ignore them altogether for AIX? idk |
|
Is this a newly backported test ? Just wondering why it would be failing consistently now versus before (if in fact 2 in a row is consistent :)) |
|
Yes, it was first added in https://github.com/nodejs/node/blob/v4.8.0/test/pseudo-tty/test-stderr-stdout-handle-sigwinch.js |
|
@Fishrock123 - other than the intermittent hang issue reported in python bug 29545 and the race condition as described in #9728, I don't see any functional issue for TTYs in AIX. I am debugging this SIGWINCH issue to see what caused the issue. |
|
I guess the idea of the test case is to make sure the _refreshSize() of the standard streams gets called when SIGWINCH is issued on the process. This is indeed happening, consistently. What is missing again, is the race condition between the child write and the parent read. I am in the process of experimenting by customizing the child spawn logic in the python parent to see if we can sync up the write-read logic. |
|
Do this test fail every time on 4.x ? |
|
@mhdawson - yes, it is pretty consistent in v4.x The test passes in master, though there is a slight change in the test code (even with nullifying the change, I see the master passing). Whereas, if I add a small delay in the v4.x case, it is consistently passing, supporting my previous update - that is, there is no new issue here, other than the race condition. I will come up with a PR to exclude this for v4.x and work on addressing the race condition |
|
For the time exclude request raised through PR #11602 |
This test is newly added to v4.x stream and is consistently failing. We have a couple of issues with pseudo-tty tests in AIX, and while the investigation is going on, need to skip this test to make CI green.
This test is newly added to v4.x stream and is consistently failing. We have a couple of issues with pseudo-tty tests in AIX, and while the investigation is going on, need to skip this test to make CI green. PR-URL: #11602 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This test is newly added to v4.x stream and is consistently failing. We have a couple of issues with pseudo-tty tests in AIX, and while the investigation is going on, need to skip this test to make CI green. PR-URL: #11602 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
The tests in pseudo-tty takes the form of child node writing some data and exiting, while parent python consume them through pseudo tty implementations, and validate the result. While there is no synchronization between child and parent, this works for most platforms, except AIX, where the child exits even before the parent could setup the read loop, under race conditions Fixing the race condition is ideally done through sending ACK messages to and forth, but involves massive changes and have side effect. The workaround is to address them in AIX alone, by adding a reasonable delay. PR-URL: nodejs#11715 Fixes: nodejs#7973 Fixes: nodejs#9765 Fixes: nodejs#11541 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
The tests in pseudo-tty takes the form of child node writing some data and exiting, while parent python consume them through pseudo tty implementations, and validate the result. While there is no synchronization between child and parent, this works for most platforms, except AIX, where the child exits even before the parent could setup the read loop, under race conditions Fixing the race condition is ideally done through sending ACK messages to and forth, but involves massive changes and have side effect. The workaround is to address them in AIX alone, by adding a reasonable delay. PR-URL: nodejs#11715 Fixes: nodejs#7973 Fixes: nodejs#9765 Fixes: nodejs#11541 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
pseudo-tty/test-stderr-stdout-handle-sigwinch failed the last two CI runs on the
v4.x-stagingbranch (started by node-daily-v4.x-staging.https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/4025/
Failed Build: https://ci.nodejs.org/job/node-test-commit/8092/
Failed Platform: https://ci.nodejs.org/job/node-test-commit-aix/4025
Actual Job: https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/4025/
cc/ @mhdawson @nodejs/platform-aix
The text was updated successfully, but these errors were encountered: