test: exclude pseudo-tty test pertinent to #11541 #11602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibfahn
approved these changes
Feb 28, 2017
test/pseudo-tty/pseudo-tty.status
Outdated
| no_interleaved_stdio : SKIP | ||
| no_dropped_stdio : SKIP | ||
| no_interleaved_stdio : SKIP | ||
| test-stderr-stdout-handle-sigwinch : SKIP |
There was a problem hiding this comment.
Maybe add a comment to the line above:
# Test issue: https://github.com/nodejs/node/issues/11541
test-stderr-stdout-handle-sigwinch : SKIP
There was a problem hiding this comment.
@gibfahn - applied the changes as suggested, thanks.
|
cc/ @nodejs/platform-aix |
cjihrig
approved these changes
Feb 28, 2017
This test is newly added to v4.x stream and is consistently failing. We have a couple of issues with pseudo-tty tests in AIX, and while the investigation is going on, need to skip this test to make CI green.
gireeshpunathil
force-pushed
the
excludesigwinch
branch
from
3b26e8a
to
2869949
Compare
|
I still think we should just mark them all as flaky on AIX. Clearly something outside of our direct control does not work correctly here. |
|
@Fishrock123 - thanks for the suggestion, and agree that we see a pattern of failures affecting AIX. But I guess the pattern is well understood (for this test as well as couple of others) as the race condition between the parent and child with respect to the message passing. Shall we wait until I address the race condition, and see how the tests are faring, before we re-assess the AIX scenario? |
gibfahn
approved these changes
Feb 28, 2017
MylesBorins
pushed a commit
that referenced
this pull request
Mar 3, 2017
This test is newly added to v4.x stream and is consistently failing. We have a couple of issues with pseudo-tty tests in AIX, and while the investigation is going on, need to skip this test to make CI green. PR-URL: #11602 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
|
landed in 3b11d89 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
This test is newly added to v4.x stream and is consistently failing. We have a couple of issues with pseudo-tty tests in AIX, and while the investigation is going on, need to skip this test to make CI green. PR-URL: #11602 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test pseudo-tty/test-stderr-stdout-handle-sigwinch is newly added
to v4.x stream and is consistently failing.
We have a couple of issues with pseudo-tty tests in AIX, and while
the investigation is going on, need to skip this test to make CI green.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)