Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc issue #12007

Closed
richardpringle opened this issue Mar 23, 2017 · 4 comments
Closed

Doc issue #12007

richardpringle opened this issue Mar 23, 2017 · 4 comments
Labels
doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Comments

@richardpringle
Copy link

richardpringle commented Mar 23, 2017

  • Version:
    6.x-latest
  • Platform:
  • Subsystem:

The link here needs to be changed to not reference the master branch md file:
https://nodejs.org/docs/latest-v6.x/api/timers.html#timers_setimmediate_callback_args

the link address is:
https://github.com/nodejs/node/blob/master/doc/topics/event-loop-timers-and-nexttick.md

(please advise if there's a better place to post this issue, or where I can submit the PR)

@evanlucas
Copy link
Contributor

That link should actually point to https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick/. @richardpringle would you be interested in opening a pull request to fix this?

@richardpringle
Copy link
Author

@EvanCarroll, I would!

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. v6.x timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Mar 23, 2017
@gibfahn
Copy link
Member

gibfahn commented Mar 24, 2017

As pointed out by @aqrln in the #12008, this was fixed in #11670, it just hasn't been backported to v6.x staging.

@MylesBorins
Copy link
Contributor

I've backported to v6.x-staging in 0cc39e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Development

No branches or pull requests

5 participants