Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix link in timers api doc. #12008

Closed
wants to merge 1 commit into from
Closed

doc: fix link in timers api doc. #12008

wants to merge 1 commit into from

Conversation

richardpringle
Copy link

@richardpringle richardpringle commented Mar 23, 2017 •
edited
Loading

Checklist
Affected core subsystem(s)

doc

Issue: #12007

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. v6.x labels Mar 23, 2017
@aqrln
Copy link
Contributor

aqrln commented Mar 23, 2017 •
edited
Loading

A similar patch is already present in master as 8402888 (#11670). I wonder why it hasn't been cherry-picked to v6.x-staging.

@gibfahn gibfahn mentioned this pull request Mar 24, 2017
Closed
@gibfahn
Copy link
Member

gibfahn commented Mar 24, 2017

@aqrln it didn't get the lts-watch tag (I've added it).

@gibfahn
Copy link
Member

gibfahn commented Mar 24, 2017

Thanks for raising this PR, @richardpringle , it looks like the previous PR that added hasn't been backported to v6.x yet, but that should happen in the next v6.x release.

I'll go ahead and close this, if you're looking for something else to contribute maybe check the good first contribution label.

@gibfahn gibfahn closed this Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardpringle @aqrln @gibfahn @vsemozhetbyt @nodejs-github-bot