Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: the url is not found #11670

Closed
wants to merge 2 commits into from
Closed

doc: the url is not found #11670

wants to merge 2 commits into from

Conversation

sushi90
Copy link
Contributor

@sushi90 sushi90 commented Mar 3, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Mar 3, 2017
@Trott
Copy link
Member

Trott commented Mar 3, 2017

Shouldn't the link go to https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick/? @cjihrig @abouthiroppy

@cjihrig
Copy link
Contributor

cjihrig commented Mar 3, 2017

Yes, that's probably better.

@sushi90
Copy link
Contributor Author

sushi90 commented Mar 4, 2017

Yes,LGTM.Have change the url to website.

Trott
Trott approved these changes Mar 4, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpinca pushed a commit to lpinca/node that referenced this pull request Mar 6, 2017
@sushi90 @lpinca
doc: fix broken URL to event loop guide
0674771 
PR-URL: nodejs#11670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca
Copy link
Member

lpinca commented Mar 6, 2017

Landed in 0674771.

@lpinca lpinca closed this Mar 6, 2017
evanlucas pushed a commit that referenced this pull request Mar 7, 2017
@sushi90 @evanlucas
doc: fix broken URL to event loop guide
8402888 
PR-URL: #11670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
Merged
@aqrln aqrln mentioned this pull request Mar 23, 2017
Closed
2 tasks
@gibfahn gibfahn mentioned this pull request Mar 24, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@sushi90 @MylesBorins
doc: fix broken URL to event loop guide
0cc39e0 
PR-URL: #11670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 29, 2017
@sushi90 @MylesBorins
doc: fix broken URL to event loop guide
47cdeb9 
PR-URL: #11670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 4, 2017
@sushi90 @MylesBorins
doc: fix broken URL to event loop guide
6486b97 
PR-URL: #11670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@sushi90 @MylesBorins
doc: fix broken URL to event loop guide
de22ff6 
PR-URL: #11670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@sushi90 @andrew749
doc: fix broken URL to event loop guide
2b8a26c 
PR-URL: nodejs/node#11670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sushi90 @Trott @cjihrig @lpinca @jasnell @hiroppy @MylesBorins @gibfahn @nodejs-github-bot