Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.10.3 proposal #12498

Merged
merged 151 commits into from
May 2, 2017
Merged

v6.10.3 proposal #12498

merged 151 commits into from
May 2, 2017

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Apr 19, 2017 •
edited
Loading

2017-05-02, Version 6.10.3 'Boron' (LTS), @MylesBorins

Notable Changes

Coming Soon

Commits

mhdawson and others added 30 commits April 18, 2017 20:01
@mhdawson @MylesBorins
doc: add supported platforms list
b9766bd 
Original Commit Message:
  PR-URL: #11872
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Rich Trott <rtrott@gmail.com>
  Reviewed-By: Roman Reiss <me@silverwind.io>
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Backport-Of: #11872
PR-URL: #11943
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson @MylesBorins
doc: add supported platforms list for v6.x
0dfb9da 
PR-URL: #11943
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sushi90 @MylesBorins
doc: fix broken URL to event loop guide
de22ff6 
PR-URL: #11670
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex @MylesBorins
stream: avoid additional validation for Buffers
f928746 
These changes result in ~50% improvement in the included benchmark.

PR-URL: #10580
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn @MylesBorins
tools, test: require const/let in test
de63698 
Backport-PR-URL: #11775
PR-URL: #10685
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@gibfahn @MylesBorins
test: use eslint to fix var->const/let
db61c95 
Manually fix issues that eslint --fix couldn't do automatically.

Backport-PR-URL: #11775
PR-URL: #10685
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@aqrln @MylesBorins
doc: fix stylistic issues in api/net.md
1604848 
* Change var to const in an example of server creation.
* Add missing semicolons.
* Use `console` syntax highlighting in `telnet` and `nc` invocation
  examples and add shell prompt symbols to be consistent with the rest
  of the documentation.

Backport-PR-URL: #11969
PR-URL: #11786
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aqrln @MylesBorins
test: add arrow functions to test-util-inspect
9162316 
Even though arrow functions and ES5 anonymous functions are technically
the same for util.js, it won't hurt to test both.

Backport-PR-URL: #11970
PR-URL: #11781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@sotayamashita @MylesBorins
test: skip when openssl CLI doesn't exist
f874256 
Backport-PR-URL: #12173
PR-URL: #11095
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@bnoordhuis @MylesBorins
build: --without-ssl implies --without-inspector
ba23506 
This cherry-picks the changes to `configure` from commit 8f00455
("inspector: switch to new inspector APIs") from the master branch
and should unbreak `--without-ssl` builds.

Refs: #12155

PR-URL: #12200
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@sam-github @MylesBorins
doc: new TLSSocket has no secure context options
c138ba3 
Unlike all the other tls APIs, if any secure context configuration is
required, the caller is responsible for creating the context.

Corrects a doc regression introduced in caa7fa9.

PR-URL: #10545
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@zbjornson @MylesBorins
doc: clarify memory sharing behavior of buffer ctor
4fd765e 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: #10778
Ref: #10770
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@edsadr @MylesBorins
test: improve test-fs-access
f064520 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: #10542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig @MylesBorins
test: refactor test-beforeexit-event-exit.js
afea1d0 
PR-URL: #10577
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn @MylesBorins
test: s/assert.equal/assert.strictEqual/
6f85c81 
Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

Backport-PR-URL: #11795
PR-URL: #10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
@gibfahn @MylesBorins
assert, tools: enforce strict (not)equal in eslint
12c0ce7 
Extend no-restricted-properties to catch use of assert.equal() and
assert.notEqual() and require assert.strictEqual() or
assert.notStrictEqual() instead.

Also update the eslint-ignore in lib/assert.js to avoid
assert.equal/notEqual linter errors in their definitions.

Backport-PR-URL: #11795
PR-URL: #10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
@DavidGoussev @MylesBorins
test: refactor test-stream2-readable-wrap.js
eb47897 
Use common.mustCall() where appropriate, var to const/let,
assert.equal() -> assert.strictEqual(), explicit time provided to
setTimeout()

Backport-PR-URL: #11797
PR-URL: #10551
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@sam-github @MylesBorins
test: getgroups() may contain duplicate GIDs
a1cb699 
Some systems may have multiple group names with the same group ID, in
which case getgroups() returns duplicate values, where `id -G` will
filter the duplicates. Unique and sort the arrays so they can be
compared.

Backport-PR-URL: #12468
PR-URL: #10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@sam-github @MylesBorins
doc,test: tls .ca option supports multi-PEM files
f1c2f26 
Backport-PR-URL: #12468
PR-URL: #10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@sam-github @MylesBorins
test: tls cert chain completion scenarios
1d7fab3 
Backport-PR-URL: #12468
PR-URL: #10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@sam-github @MylesBorins
doc: use correct tls certificate property name
cbfc3fc 
Docs referred to an `issuer` property being optionally present, when it
should have referred to the `issuerCertificate` property.

Backport-PR-URL: #12468
PR-URL: #10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@sam-github @MylesBorins
test: check tls server verification with addCACert
4207bce 
SecureContext.addCACert() adds to the existing root store,
preserving root cert entries. option.ca is applied without
calling SecureContext.addRootCerts() so should add to
the default, empty, root store.

This test confirms that the built-in root CAs are not included
when options.ca is used.

Based on:

shigeki@acd5837

Backport-PR-URL: #12468
PR-URL: #10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@sam-github @MylesBorins
test: move common tls connect setup into fixtures
4575f92 
TLS connection setup boilerplate is common to many TLS tests, factor it
into a test fixture so tests are clearer to read and faster to write.

Backport-PR-URL: #12468
PR-URL: #10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@evanlucas @MylesBorins
doc: make os api doc more consistent
c9b302b 
This adds a missing Returns to os.arch() as well as a missing added in
version to os.constants.

PR-URL: #10994
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@seishun @MylesBorins
doc: fix typo in STYLE_GUIDE.md
6c3b104 
PR-URL: #11615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jsumners @MylesBorins
doc: use common malformed instead of misformatted
109fd72 
PR-URL: #11518
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@joyeecheung @MylesBorins
doc: add link to references in net.Socket
0aab050 
PR-URL: #11625
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@thefourtheye @MylesBorins
test: skip tests with common.skip
0322d3b 
The `common.skip` function adds proper message in TAP format to skipped
tests. It is better not to have the message rewritten in the tests.

PR-URL: #11585
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@vsemozhetbyt @MylesBorins
doc: fixup errors.md
c0663e5 
* add semicolons in examples
* fix indentation in code example
* add spaces in code examples
* console.log() -> console.error()
* fix level of headings
* update comment code example
* delete obsolete info and example

Fixes: #11558
PR-URL: #11566
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@bnoordhuis @MylesBorins
net: remove misleading comment
06752d1 
The allowHalfOpen comment was added in commit 8a3befa ("net: Refactor
to use streams2") from 2012 but it wasn't true even then as far as I
can tell: Node.js simply always does a shutdown(2) first.

It is true that streams2 withholds the 'end' event when allowHalfOpen
is true but the comment is about a callback that hangs off the 'finish'
event that is emitted after calling `socket.end()`.

PR-URL: #11573
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor Author

@sam-github how did you generate this list?

Most of those have not landed for a variety of reasons

  • The need to bake longer
  • Waiting for larger work to come at once (renaming)
  • Have enquired about if they should land
  • waiting for backport

FWIW it is not important that EVERYTHING that can backport makes it to each release, more so that we make a good effort to land them. Please feel free to audit your list and land anything that obviously should land. Randomly clicking on handful had them all in one of the states of LTS-purgatory, perhaps we need a label for things in that stage to filter
¯\_(ツ)_/¯

@sam-github
Copy link
Contributor

@MylesBorins I forgot to exclude the backport-requested, oops. Updated: branch-diff -g --filter-release --exclude-label=semver-major,semver-minor,meta,dont-land-on-v6.x,backport-requested-to-v6.x upstream/v6.10.3-proposal upstream/v7.x

So, I think what's left either should land or is not yet labelled. I know many of the PRs have comments from you asking if they should land ("LTS purgatory"), so they are not yet labelled as to their disposition because its unknown. Maybe a label for that would be useful, maybe that's what lts-watch should mean? Too bad we can't put permissions on github labels.

@MylesBorins
Copy link
Contributor Author

@sam-github that's what I've been using LTS watch for... fwiw now that I've cut the RC I do not plan to backport anything else unless it is an obvious bug or fix. We can start landing other stuff in staging once the release goes out

seishun and others added 6 commits April 24, 2017 13:29
@seishun @MylesBorins
doc: clarify out-of-bounds behavior of buf[index]
03f9388 
PR-URL: #11286
Fixes: #11244
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
@bzoz @MylesBorins
src: add fcntl.h include to node.cc
c667e6e 
#11863 adds _O_RDWR to node.cc
which is defined in fcntl.h. This adds this include directly to
node.cc.

PR-URL: #12540
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@danbev @MylesBorins
deps: backport ec1ffe3 from upstream V8
62e047e 
This commit adds lldbinit files from upstream V8 and also adds these so
that they get installed when `make install` is run.

Original commit message:

[tools] add lldbinit

    The goal of this commit is to add the equivalent to gdbinit but
    for lldb. I've tried to replicate the commands as close as possible
    but I'm unsure about the jss command and hoping to get some feedback
    on it in addition to the bta command which I'm not sure how/when
    this could be used. This is probably just inexperience on my part.

    The lldbinit file can be placed into a directory prefixed with dot
    (.lldbinit) and the python script is currently expected to be in the
    same directory. The path to the script can be changed manually if
    needed as well.

    NOTRY=true

    Review-Url: https://codereview.chromium.org/2758373002
    Cr-Commit-Position: refs/heads/master@{#44136}

PR-URL: #12061
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@vsemozhetbyt @MylesBorins
doc: modernize and fix code examples in modules.md
d15188f 
* Replace `var` by `const`.
* Fix semicolons.
* Add missing code marks.
* Unify quotes.
* Comment out ellipsis.
* Use object destructuring.
* Replace snake_case by camelCase.

Backport-PR-URL: #12500
PR-URL: #12224
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@gibfahn @MylesBorins
build: use $(RM) in Makefile for consistency
e7e83f6 
Also allows someone to reassign `$RM`, e.g. with `RM=rm -v` instead of
`rm -f` (the default) should they want to. We're currently using a
mixture of `$(RM)` and `rm -f`.

There are a couple of places which aren't doing -f, have them do it for
consistency.

Backport-PR-URL: #12515
PR-URL: #12157
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@hashseed @MylesBorins
deps: backport 75f2d65f00 from upstream V8
cd78a2b 
Original commit message:

    Don't treat catch scopes as possibly-shadowing for sloppy eval

    Scope analysis is over-conservative when treating variable
    resolutions as possibly-shadowed by a sloppy eval. In the attached
    bug, this comes into play since catch scopes have different behavior
    with respect to the "calls eval" in eager vs lazy compilation (in
    the latter, they are never marked as "calls eval" because
    CatchContexts don't have an associated ScopeInfo).

    This patch changes the scope-type check to also eliminate a few
    other cases where shadowing isn't possible, such as non-declaration
    block scopes.

    BUG=chromium:608279
    LOG=n

    Committed:
    https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b
    Cr-Commit-Position: refs/heads/master@{#36046}

Fixes: #12308

PR-URL: #12535
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BethGriggs @MylesBorins
test: refactor several parallel/test-timer tests
aae3765 
Change var to const/let. Simplify test-timers-uncaught-exception.

Backport-PR-URL: #12401
PR-URL: #10524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins added a commit that referenced this pull request Apr 24, 2017
@MylesBorins
2017-05-02, Version 6.10.3 'Boron' (LTS)
d90a948 
Notable Changes:

Coming Soon

PR-URL: #12498
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Apr 24, 2017 •
edited
Loading

ci: https://ci.nodejs.org/job/node-test-pull-request/7650/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/724/
citgm-without-J: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/726/
citgm 6.10.2 without-j: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/731/

rc.1: https://nodejs.org/download/rc/v6.10.3-rc.1/

edit: CI is looking good but we have an absurd amount of failures on citgm

@rvagg rvagg mentioned this pull request Apr 25, 2017
Closed
@rvagg
Copy link
Member

rvagg commented Apr 25, 2017

citgm issue addressed @ nodejs/citgm#399

@MylesBorins
Copy link
Contributor Author

One more run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/744/

thanks @gibfahn

@MylesBorins
Revert "src: fix delete operator on vm context"
bed6acb 
This reverts commit 587857e. It was found to have subtle
behavior changes in deleting objects.

PR-URL: #12721
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins added a commit that referenced this pull request Apr 29, 2017
@MylesBorins
2017-05-02, Version 6.10.3 'Boron' (LTS)
9ecb9e0 
Notable Changes:

Coming Soon

PR-URL: #12498
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Apr 29, 2017 •
edited
Loading

rc.2: https://nodejs.org/download/rc/v6.10.3-rc.2/

ci: https://ci.nodejs.org/job/node-test-pull-request/7743/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/750/

@MylesBorins
Copy link
Contributor Author

Review of failures

ubuntu1604-64

  • same infra related failures as v4.x... can't repro on fresh box

fedora 22:

  • spdy ~ timeout

fedora 23

  • uglify-js ~

To Be Continued in an edit

@addaleax addaleax mentioned this pull request Apr 30, 2017
Closed
@MylesBorins
Copy link
Contributor Author

One more for prosperity

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/755/

@MylesBorins
Copy link
Contributor Author

All CITGM failures are expected. @nodejs/build as mentioned in other thread we should get to the bottom of the inconsistent failures with uglify

@MylesBorins
2017-05-02, Version 6.10.3 'Boron' (LTS)
a0bfd4f 
Notable Changes:

* module:
  - The module loading global fallback to the Node executable's
    directory now works correctly on Windows.
    (Richard Lau) #9283
* src:
  - fix base64 decoding in rare edgecase
    (Nikolai Vavilov) #11995
* tls:
  - fix rare segmentation faults when using TLS
   * (Trevor Norris) #11947
   * (Ben Noordhuis) #11898
   * (jBarz) #11776

PR-URL: #12497
@MylesBorins MylesBorins merged commit a0bfd4f into v6.x May 2, 2017
@gibfahn gibfahn deleted the v6.10.3-proposal branch May 2, 2017 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.