Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document the performance team #12213

Merged
merged 1 commit into from
Apr 8, 2017
Merged

doc: document the performance team #12213

merged 1 commit into from
Apr 8, 2017

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Apr 4, 2017 •
edited
Loading

Can be cc'ed with @nodejs/performance.

I added some people: @mscdex @vsemozhetbyt @joyeecheung @TimothyGu @lpinca

If anyone else wants to join and be cc/ed on issues, feel free to request access (or remove yourself if you don't want to be on the team).

Link to team

Refs: #12194 (comment)

Checklist
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 4, 2017
joyeecheung
joyeecheung approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is quick. Thanks!

@lpinca
Copy link
Member

lpinca commented Apr 4, 2017 •
edited
Loading

@gibfahn thanks but I don't consider myself a performance expert :) gonna remove myself from the team.

@lpinca
Copy link
Member

lpinca commented Apr 4, 2017

I think @mcollina and @trevnorris are good candidates for the team instead.

@mcollina
Copy link
Member

mcollina commented Apr 4, 2017

I've just request access.

mcollina
mcollina approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca
Copy link
Member

lpinca commented Apr 4, 2017

Also @petkaantonov if he is still active.

@lpinca
Copy link
Member

lpinca commented Apr 4, 2017

One last: @benjamingr, sorry about the spam.

P.S. I'm probably missing other good candidates :)

joyeecheung
joyeecheung reviewed Apr 4, 2017
View reviewed changes
doc/onboarding-extras.md
@@ -27,6 +27,7 @@
| `test/*` | @nodejs/testing |
| `tools/eslint`, `.eslintrc` | @not-an-aardvark, @silverwind, @trott |
| async_hooks | @nodejs/diagnostics |
| performance | @nodejs/performance |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed.. should we replace the row for benchmark/* above too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered it, but I'm not sure. That's probably a question for @nodejs/benchmarking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It already has @nodejs/benhmarking and mscdex is not part of that team but is interested in the core benchmarks

@vsemozhetbyt
Copy link
Contributor

Maybe @fhinkel would be interested.

@benjamingr
Copy link
Member

Sure

@gibfahn
Copy link
Member Author

gibfahn commented Apr 4, 2017 •
edited
Loading

Added all the people mentioned, that way they can leave if they want.

EDIT: You're all team maintainers, so if you want to add someone go for it!

@gibfahn thanks but I don't consider myself a performance expert :) gonna remove myself from the team.

@lpinca The idea isn't that these are a list of performance experts (otherwise it'd probably be a short list 😁 ). It's just to have a list of people who are willing to look at performance issues and PRs. Feel free to remove yourself if you want, but being in the team doesn't mean you have to approve PRs or anything.

mhdawson
mhdawson approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/onboarding-extras.md
@@ -27,6 +27,7 @@
| `test/*` | @nodejs/testing |
| `tools/eslint`, `.eslintrc` | @not-an-aardvark, @silverwind, @trott |
| async_hooks | @nodejs/diagnostics |
| performance | @nodejs/performance |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It already has @nodejs/benhmarking and mscdex is not part of that team but is interested in the core benchmarks

@mscdex mscdex added the performance Issues and PRs related to the performance of Node.js. label Apr 4, 2017
@gibfahn
doc: document the performance team
96619fc 
Can be cc'ed with `@nodejs/performance`.

PR-URL: nodejs#12213
Refs: nodejs#12194 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gibfahn gibfahn merged commit 96619fc into nodejs:master Apr 8, 2017
@gibfahn gibfahn deleted the perf-team branch April 8, 2017 09:57
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
@gibfahn @italoacasas
doc: document the performance team
376f5ef 
Can be cc'ed with `@nodejs/performance`.

PR-URL: nodejs#12213
Refs: nodejs#12194 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@gibfahn @MylesBorins
doc: document the performance team
c520aef 
Can be cc'ed with `@nodejs/performance`.

PR-URL: #12213
Refs: #12194 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@gibfahn @MylesBorins
doc: document the performance team
7e67176 
Can be cc'ed with `@nodejs/performance`.

PR-URL: #12213
Refs: #12194 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@gibfahn @andrew749
doc: document the performance team
ca0034d 
Can be cc'ed with `@nodejs/performance`.

PR-URL: nodejs/node#12213
Refs: nodejs/node#12194 (comment)
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.