Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fixed readable.isPaused() 'Added in version' annotation #11677

Closed
wants to merge 1 commit into from

Conversation

lfortin
Copy link
Contributor

@lfortin lfortin commented Mar 3, 2017

readable.isPaused(): added a missing YAML placeholder so the 'Added in version' annotation can be displayed in docs.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

readable.isPaused(): added a missing YAML placeholder so the 'Added to version' annotation is displayed in docs
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Mar 3, 2017
@addaleax
Copy link
Member

addaleax commented Mar 6, 2017

Landed in 672d752, thanks for the PR!

@addaleax addaleax closed this Mar 6, 2017
addaleax pushed a commit that referenced this pull request Mar 6, 2017
readable.isPaused(): added a missing YAML placeholder
so the 'Added to version' annotation is displayed in docs

PR-URL: #11677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
evanlucas pushed a commit that referenced this pull request Mar 7, 2017
readable.isPaused(): added a missing YAML placeholder
so the 'Added to version' annotation is displayed in docs

PR-URL: #11677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
@lfortin
Copy link
Contributor Author

lfortin commented Mar 9, 2017

This could also be backported to v6 (LTS): #11759

@gibfahn
Copy link
Member

gibfahn commented Mar 12, 2017

@lfortin added the tag, should go into the next v6 release (probably too late for this one).

MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
readable.isPaused(): added a missing YAML placeholder
so the 'Added to version' annotation is displayed in docs

PR-URL: #11677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins
Copy link
Contributor

@lfortin got you on that backport :p

@lfortin
Copy link
Contributor Author

lfortin commented Apr 18, 2017

@gibfahn @MylesBorins thanks!

MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
readable.isPaused(): added a missing YAML placeholder
so the 'Added to version' annotation is displayed in docs

PR-URL: #11677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
readable.isPaused(): added a missing YAML placeholder
so the 'Added to version' annotation is displayed in docs

PR-URL: nodejs/node#11677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants